Paul Stack
0834f994de
provider/aws: Guard clause to prevent panic on ELB connectionSettings ( #12685 )
...
Fixes : #11705
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSELB_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/14 16:40:20 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSELB_ -timeout 120m
=== RUN TestAccAWSELB_importBasic
--- PASS: TestAccAWSELB_importBasic (73.93s)
=== RUN TestAccAWSELB_basic
--- PASS: TestAccAWSELB_basic (69.20s)
=== RUN TestAccAWSELB_fullCharacterRange
--- PASS: TestAccAWSELB_fullCharacterRange (63.68s)
=== RUN TestAccAWSELB_AccessLogs_enabled
--- PASS: TestAccAWSELB_AccessLogs_enabled (196.25s)
=== RUN TestAccAWSELB_AccessLogs_disabled
--- PASS: TestAccAWSELB_AccessLogs_disabled (190.90s)
=== RUN TestAccAWSELB_generatedName
--- PASS: TestAccAWSELB_generatedName (52.09s)
=== RUN TestAccAWSELB_availabilityZones
--- PASS: TestAccAWSELB_availabilityZones (93.53s)
=== RUN TestAccAWSELB_tags
--- PASS: TestAccAWSELB_tags (102.96s)
=== RUN TestAccAWSELB_iam_server_cert
--- PASS: TestAccAWSELB_iam_server_cert (70.91s)
=== RUN TestAccAWSELB_swap_subnets
--- PASS: TestAccAWSELB_swap_subnets (261.42s)
=== RUN TestAccAWSELB_InstanceAttaching
--- PASS: TestAccAWSELB_InstanceAttaching (196.82s)
=== RUN TestAccAWSELB_HealthCheck
--- PASS: TestAccAWSELB_HealthCheck (60.64s)
=== RUN TestAccAWSELB_Timeout
--- PASS: TestAccAWSELB_Timeout (62.71s)
=== RUN TestAccAWSELB_ConnectionDraining
--- PASS: TestAccAWSELB_ConnectionDraining (58.25s)
=== RUN TestAccAWSELB_SecurityGroups
--- PASS: TestAccAWSELB_SecurityGroups (153.64s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 1706.980s
```
2017-03-14 19:54:16 +02:00
Clint
c0d0f711d9
provider/aws: Allow disabled access_log in ELB ( #11120 )
...
* provider/aws: Save disabled ELB accesslogs to state
Save any explicitly disabled access_log to state. Do not save disabled
access_logs if they are not in the configuration.
* test that fails on master
2017-01-09 23:10:58 +00:00
Clint
7337a346ec
provider/aws: Fix issue with updating ELB subnets for subnets in the same AZ ( #9131 )
...
* provider/aws: Regression test for #9120
* provider/aws: Fix issue with updating ELB subnets for subnets in the same AZ
2016-09-29 13:01:09 -05:00
Krzysztof Wilczynski
bcaac02edb
Add validation of Health Check target to aws_elb.
...
This commit adds a simple validation of the target in the Health Check block in
order to reduce the number of issues related to the type, port and path values,
especially when the TCP and SSL type was used.
Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
2016-09-03 13:48:28 +01:00
Anshul Sharma
f034638026
Enable/Disbale Option For ELB Access logs
2016-08-24 14:37:47 +05:30
Clint
3cea29176f
provider/aws: Safely get ELB values ( #7585 )
...
- removes dereferences to avoid nil crashes
2016-07-13 10:07:56 +01:00
Radek Simko
120d7c4f2e
provider/aws: Only allow max. 1 health_check block for ELB
2016-07-05 10:56:17 +01:00
Anshul Sharma
1f28bf0a74
set cross_zone_load_balancing default to true ( #6897 )
...
https://github.com/hashicorp/terraform/issues/6891
2016-06-02 12:08:46 +01:00
Mitchell Hashimoto
830708a882
providers/aws: elb
2016-05-16 10:03:57 -07:00
Paul Stack
6ac312e682
provider/aws: Set the state of `cross_zone_load_balancing` during the read func ( #6295 )
...
Changes made manually to the ELB property were not being set and
Terraform was reporting now changes to infra was to be made on refresh
2016-04-22 01:47:19 +01:00
Paul Stack
12546c6fca
Merge pull request #5065 from tpounds/fix-aws-elb-access-logs-type
...
provider/aws: Change ELB access_logs to list type
2016-03-22 01:40:14 +00:00
Clint
239b3e4f5f
Merge pull request #5533 from hashicorp/pr-5184
...
provider/aws: Fix EC2 Classic SG Rule issue
2016-03-10 08:56:29 -06:00
Paul Hinze
108ccf0007
builtin: Refactor resource.Retry to clarify return
...
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.
Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.
This makes it eminently clear whether or not a given error is
retryable from inside the client code.
Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
ephemeralsnow
54cb5ffe00
provider/aws: Fix EC2 Classic SG Rule issue
...
Fixes an issue where security groups would fail to update after applying an
initial security_group, because we were improperly saving the id of the group
and not the name (EC2 Classic only).
This is a PR combining https://github.com/hashicorp/terraform/pull/4983 and
https://github.com/hashicorp/terraform/pull/5184 . It's majority
@ephemeralsnow's work.
2016-03-09 09:51:41 -06:00
Paul Stack
30dcc45635
Merge pull request #5178 from hashicorp/f-aws-iam-server-updates
...
provider/aws: Update IAM Server Cert
2016-02-22 18:07:22 +00:00
Trevor Pounds
f83c81dbb5
Change AWS ELB access_logs to list type.
...
There can only be a single access_log configuration per load balancer
so choosing to use a list over a set is only relevant when comparing
changes during a plan. A list makes it much easier to compare updates
since the index is stable (0 vs. computed hash).
2016-02-21 15:16:09 -08:00
clint shryock
c8178ad31c
provider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesprovider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesdiff
2016-02-17 16:34:02 -06:00
Trevor Pounds
5624a33239
Change AWS ELB health_check to list type.
...
There can only be a single health_check configuration per load balancer
so choosing to use a list over a set is only relevant when comparing
changes during a plan. A list makes it much easier to compare updates
since the index is stable (0 vs. computed hash).
2016-02-08 23:08:35 -08:00
clint shryock
86ad4c4340
provider/aws: Retry Listener Creation for ELBs
2016-01-25 11:38:04 -06:00
Trevor Pounds
76e23a3b2e
Fix ELB security groups read logic.
2016-01-09 16:09:14 -08:00
Trevor Pounds
c34c2249e7
Support updating ELB availability zones.
2016-01-09 15:40:21 -08:00
Trevor Pounds
f75c3168d7
Support updating ELB subnets.
2016-01-09 15:40:21 -08:00
Trevor Pounds
9541c37ef4
Fix ELB availability zones and subnets read logic.
2016-01-09 15:40:21 -08:00
Radek Simko
a367886eaf
provider/aws: Separate existing validate functions
2015-12-23 15:11:45 +01:00
Anthony Stanton
5753efa8af
Skip SG ID determination logic for Classic ELBs
2015-11-26 15:34:28 +01:00
clint shryock
6fa69ede1c
add debugging statements to add/remove listeners
2015-11-12 16:20:54 -06:00
clint shryock
c60a963908
providers/aws: Retry deleting IAM Server Cert on dependency violation
...
This will retry deleting a server cert
if it throws an error about being in use with an ELB (that we've likely just
deleted)
Includes test for ELB+IAM SSL cert bug dependency violation
2015-11-12 16:07:34 -06:00
clint shryock
8c32536f3d
return err if we fail to set access_logs; other cleanups
2015-11-10 16:58:24 -06:00
clint shryock
0a1890c329
Merge branch 'master' into pr-3708
...
* master: (95 commits)
Update CHANGELOG.md
Update CHANGELOG.md
Update CHANGELOG.md
Update CHANGELOG.md
upgrade a warning to error
add some logging around create/update requests for IAM user
Update CHANGELOG.md
Update CHANGELOG.md
Build using `make test` on Travis CI
Update CHANGELOG.md
provider/aws: Fix error format in Kinesis Firehose
Update CHANGELOG.md
Changes to Aws Kinesis Firehouse Docs
Update CHANGELOG.md
modify aws_iam_user_test to correctly check username and path for initial and changed username/path
Update CHANGELOG.md
Update CHANGELOG.md
Prompt for input variables before context validate
Removing the AWS DBInstance Acceptance Test for withoutEngine as this is now part of the checkInstanceAttributes func
Making engine_version be computed in the db_instance provider
...
2015-11-10 16:52:45 -06:00
clint shryock
7152674f9b
upgrade a warning to error
2015-11-10 16:27:41 -06:00
clint shryock
9390674a05
providers/aws: Provide source security group id for ELBs
2015-11-05 16:43:49 -06:00
clint shryock
5f7254eb1a
providers/aws: Add ELB Access Logs (continues #3708 )
...
- continues #3708
- adds some tests
- other fixes I found along the way
2015-11-04 11:58:29 -06:00
clint shryock
2e03a7ebff
go fmt after rebase
2015-11-03 16:30:18 -06:00
Trevor Pounds
4e3d0b5f6c
Fix schema conversion.
2015-11-03 16:29:57 -06:00
Trevor Pounds
91b1d0c23d
Can only set access logs once per ELB.
2015-11-03 16:29:57 -06:00
Trevor Pounds
e8f1f57ead
Fix int64 cast.
2015-11-03 16:29:57 -06:00
Florin Patan
e173b60f10
Changes per feedback
2015-11-03 16:29:57 -06:00
Florin Patan
e390d7ddf2
Add elb access logs setting
2015-11-03 16:29:57 -06:00
stack72
91274c9a90
Test spike to extract the function that does the validation for ELB Name. This will allow me to test this in isolation to make sure that the validation rules work as expected
2015-09-21 22:00:51 +01:00
Paul Hinze
55411d692d
provider/aws: add value into ELB name validation message
...
makes debugging these validation errors much more straightforward
2015-08-13 16:31:18 -05:00
Clint Shryock
579ccbefea
provider/aws: Update source to comply with upstream breaking change
2015-07-28 15:29:46 -05:00
Clint
f979fd7dee
Merge pull request #2571 from TimeIncOSS/f-aws-autogenerated-elb-name
...
provider/aws: Allow ELB name to be generated
2015-07-21 15:52:36 -05:00
Panagiotis Moustafellos
0cbb815d28
providers/aws: aws_elb: Allow alnum plus hyphen in name attribute
2015-07-01 09:16:32 +03:00
Radek Simko
676d490d40
provider/aws: Allow elb name to be generated
2015-06-30 13:13:51 +01:00
Radek Simko
60a7597a4c
aws: Fix validation for aws_elb.name
2015-06-26 18:08:13 +01:00
Radek Simko
6f2fb0db38
provider/aws: Add validation for aws_elb.name
2015-06-26 15:08:00 +01:00
Paul Hinze
f65cce478b
provider/aws: fix case in ELB listener protocols
...
fixes #2242
2015-06-05 10:20:07 -05:00
Paul Hinze
b71fa3d0ae
provider/aws: handle upstream aws-sdk-go repo move
...
`awslabs/aws-sdk-go => aws/aws-sdk-go`
Congrats to upstream on the promotion. :)
2015-06-03 13:36:57 -05:00
Paul Hinze
31258e06c6
provider/aws: fix breakages from awserr refactor
...
This landed in aws-sdk-go yesterday, breaking the AWS provider in many places:
3c259c9586
Here, with much sedding, grepping, and manual massaging, we attempt to
catch Terraform up to the new `awserr.Error` interface world.
2015-05-20 06:21:23 -05:00
Clint Shryock
f6bcc302d3
providers/aws+cloudflare+dnsimple: Increase some verbosity
2015-05-18 15:25:03 -05:00