Chris Love
1d1de992af
adding better acceptance test to check custom config
2015-11-25 05:41:01 +00:00
Chris Love
a35b65e5d2
working on better test
2015-11-24 21:35:40 -07:00
chrislovecnm
98167cea79
merging upstream master
2015-11-18 16:09:05 -07:00
clint shryock
fd251e8b45
rename TestAccAWSRoute53Record_weighted to TestAccAWSRoute53Record_weighted_basic to test in isolation
2015-11-18 16:08:23 -06:00
Clint
5024d66f3c
Merge pull request #3970 from hashicorp/b-aws-iam-policy-attachfix
...
providers/aws: Fix typo in error checking for IAM Policy Attachments
2015-11-18 13:57:03 -06:00
clint shryock
5482e98927
Fix typo in error checking for IAM Policy Attachments
2015-11-18 13:48:46 -06:00
Paul Hinze
a211fc3469
Merge pull request #3965 from hashicorp/b-aws-sg-rules-v2-race
...
provider/aws: serialize SG rule access to fix race condition
2015-11-18 12:47:55 -06:00
Paul Hinze
6b6b5a43c3
provider/aws: serialize SG rule access to fix race condition
...
Because `aws_security_group_rule` resources are an abstraction on top of
Security Groups, they must interact with the AWS Security Group APIs in
a pattern that often results in lots of parallel requests interacting
with the same security group.
We've found that this pattern can trigger race conditions resulting in
inconsistent behavior, including:
* Rules that report as created but don't actually exist on AWS's side
* Rules that show up in AWS but don't register as being created
locally, resulting in follow up attempts to authorize the rule
failing w/ Duplicate errors
Here, we introduce a per-SG mutex that must be held by any security
group before it is allowed to interact with AWS APIs. This protects the
space between `DescribeSecurityGroup` and `Authorize*` / `Revoke*`
calls, ensuring that no other rules interact with the SG during that
span.
The included test exposes the race by applying a security group with
lots of rules, which based on the dependency graph can all be handled in
parallel. This fails most of the time without the new locking behavior.
I've omitted the mutex from `Read`, since it is only called during the
Refresh walk when no changes are being made, meaning a bunch of parallel
`DescribeSecurityGroup` API calls should be consistent in that case.
2015-11-18 12:39:59 -06:00
Nashwan Azhari
da8314ce8a
provider/aws: removed build-blocking unused variable.
2015-11-18 15:08:45 +02:00
Joe Topjian
51a2fbd6ae
Merge pull request #3927 from jtopjian/jtopjian-openstack-lbvip-attr-cleanup
...
provider/openstack: Clean up some attributes in LBaaS VIP resource
2015-11-17 20:19:25 -07:00
Radek Simko
306046b82b
Merge pull request #3955 from cbusbey/db_subnet_spaces
...
allow spaces in db subnet name
2015-11-17 22:38:36 +00:00
Clint
0bd8b32637
Merge pull request #3237 from GrayCoder/group-work
...
provider/aws: add support for group name and path changes with group update function
2015-11-17 16:37:40 -06:00
Chris Love
a5690b7510
removing debug print statements
2015-11-17 22:00:46 +00:00
Chris Busbey
12d51edeb6
allow spaces in db subnet name
2015-11-17 12:48:56 -08:00
Clint
2ed867b5ab
Merge pull request #3945 from hashicorp/b-aws-r53-record-zone-fix
...
provider/aws: Fix crash in Route53 Record if Zone not found
2015-11-17 09:10:50 -06:00
James Nugent
edaaab9f62
Merge pull request #3948 from pshima/f-packet-net-provisioner-ip
...
Populate the provisioner connection info for packet.net devices
2015-11-17 13:26:10 +00:00
Pete Shima
e2ef92f50f
Populate the provisioner connection info for packet.net devices with the ipv4 public address
2015-11-16 21:02:57 -08:00
Paul Hinze
7e59d7f67c
Merge pull request #3901 from hashicorp/phinze/google-credentials
...
provider/google: read credentials as contents instead of path
2015-11-16 17:57:54 -06:00
Paul Hinze
010293992a
Merge pull request #3899 from hashicorp/phinze/azure-publish-settings
...
provider/azure: read publish_settings as contents instead of path
2015-11-16 17:54:43 -06:00
Paul Hinze
fb0dc4951d
provider/azure: read publish_settings as contents instead of path
...
Building on the work in #3846 , shifting the Azure provider's
configuration option from `settings_file` to `publish_settings`.
2015-11-16 17:47:56 -06:00
Radek Simko
00d0551933
aws: Add missing dereference operator
2015-11-16 23:19:45 +00:00
clint shryock
1413d032ee
provider/aws: Fix crash in Route53 Record if Zone not found
2015-11-16 17:15:17 -06:00
clint shryock
901e5fbf9f
fix log reference
2015-11-16 17:14:02 -06:00
clint shryock
8085e55eda
fix issue with undefined var
2015-11-16 16:29:52 -06:00
Radek Simko
a8ceda1b15
Merge pull request #3914 from TimeIncOSS/b-aws-ecs-service-gone
...
provider/aws: Prevent crashing when deleting ecs_service which is gone
2015-11-16 21:46:06 +00:00
Paul Hinze
eb9a93862b
provider/google: read credentials as contents instead of path
...
Building on the work in #3846 , shifting the Google provider's
configuration option from `account_file` to `credentials`.
2015-11-16 15:14:32 -06:00
Paul Hinze
993ec0a320
Merge pull request #3909 from hashicorp/phinze/template-file-contents
...
template_file: source contents instead of path
2015-11-16 14:50:45 -06:00
Sander van Harmelen
0cdc81f390
Merge pull request #3896 from hashicorp/phinze/chef-keys-as-contents
...
chef: read key contents instead of paths
2015-11-16 21:44:09 +01:00
Paul Hinze
afb416fba4
Merge pull request #2807 from dwradcliffe/f-dyn-provider
...
add Dyn provider
2015-11-16 13:53:44 -06:00
Radek Simko
5c59bd95cb
Merge pull request #3924 from TimeIncOSS/b-aws-ecs-td-computed
...
provider/aws: Make all fields in ecs_task_definition ForceNew
2015-11-16 15:31:17 +00:00
Rafal Jeczalik
4f25b552bb
use single import path for aws-sdk-go
2015-11-16 00:42:08 +01:00
Joe Topjian
b4242e6f35
provider/openstack: Clean up some attributes in LBaaS VIP resource
...
This commit makes a few attributes computed so the generated information
is accessible after creation.
It also fixes the "persistence" attribute, which previously had a typo.
Finally, it converts "admin_state_up" to a Boolean to match the majority
of other attributes of the same name.
2015-11-14 21:16:23 +00:00
Radek Simko
33ca2a796f
Fix typo (Modifier -> Modified)
2015-11-14 12:19:29 +00:00
Radek Simko
308edd6dd7
provider/aws: Make all fields in ecs_task_definition ForceNew
...
- fixes https://github.com/hashicorp/terraform/issues/2694
2015-11-14 10:36:01 +00:00
Radek Simko
aae8fc8494
provider/aws: Add acceptance test for bugfix for #2694
2015-11-14 10:34:17 +00:00
Radek Simko
d5ae5ba062
Merge pull request #3910 from hashicorp/phinze/s3-object-homedir-expand
...
provider/aws: homedir expand in s3 object source
2015-11-14 09:35:09 +00:00
Radek Simko
e7c88eab35
openstack: fix go vet error (bool modifier is %t)
2015-11-14 08:19:22 +00:00
Joe Topjian
19fc2193f4
Merge pull request #3904 from jtopjian/jtopjian-openstack-port-attr-cleanup
...
provider/openstack: Make Networking Port attributes more intuitive
2015-11-13 20:15:29 -07:00
Joe Topjian
f2a5064538
Merge pull request #3857 from jtopjian/jtopjian-openstack-secgroup-rule-fix2
...
provider/openstack: Security Group Rule fixes
2015-11-13 20:13:46 -07:00
Radek Simko
0822776de0
provider/aws: If ecs_service isn't found during Read, delete it
2015-11-13 21:45:21 +00:00
Radek Simko
d9a5de7f7d
provider/aws: Prevent crashing when deleting ecs_service which is gone
...
- fixes https://github.com/hashicorp/terraform/issues/3868
2015-11-13 21:42:29 +00:00
clint shryock
7d94c86958
go fmt structure files
2015-11-13 13:53:52 -06:00
Chris Love
50d36f108b
merging
2015-11-13 12:52:07 -07:00
Chris Love
ce6f0ae5e4
testing finished
2015-11-13 12:49:40 -07:00
Chris Love
6615285d63
working on read and more testing
2015-11-13 12:49:40 -07:00
Chris Love
8c47441a8b
adding new functional test
2015-11-13 12:49:06 -07:00
Chris Love
cae7fd8e4a
fixing if and AnyTypes
2015-11-13 12:47:17 -07:00
Chris Love
b47d1cda7c
adding capability to set custom configuration value in virtual machines
2015-11-13 12:47:17 -07:00
Chris Love
0f46b3a6c5
working on read and more testing
2015-11-13 12:43:06 -07:00
Chris Love
728b2bed63
adding new functional test
2015-11-13 12:43:06 -07:00