Paul Hinze
c7dc1c10a3
helper/schema: skip StateFunc when value is nil
...
This takes the nil checking burden off of StateFunc.
fixes #3586 , see that issue for further discussion
2015-11-20 14:07:18 -06:00
Paul Hinze
5ec446718a
Merge pull request #4000 from hashicorp/phinze/keys-for-schema-test-cases
...
helper/schema: name test cases w/ strings
2015-11-20 14:06:37 -06:00
Paul Hinze
938281024f
helper/schema: name test cases w/ strings
...
I promised myself that next time I jumped in this file I'd fix this up.
Now we don't have to manually index the file with comments, we can just
add descriptive names to the test cases!
2015-11-20 13:51:34 -06:00
Clint
ed3399593a
Merge pull request #3996 from hashicorp/b-aws-test-fixes
...
Adjustments for AWS Acceptance tests
2015-11-20 13:28:25 -06:00
clint shryock
9eb46c28b2
use a log group resourcE
2015-11-20 13:15:20 -06:00
clint shryock
cf5b32617b
fix vpn gateway refresh/reattach issue
2015-11-20 11:47:10 -06:00
stack72
74c93d3a46
Reording the code for the creation of a Floating IP for a droplet. The call to the DO api takes a few seconds to propagate so I had to sacriface some kittens and added a short 10 second sleep
2015-11-20 19:12:31 +02:00
stack72
7bda855590
Adding the work to assign a Floating IP to a Droplet
2015-11-20 19:12:31 +02:00
stack72
9cf1c2943c
Adding the first pass of the work to get a floatingip assigned to a region
2015-11-20 19:12:30 +02:00
Paul Hinze
24d15820c1
provider/heroku: fix acc test
...
depends_on requires a list of strings. the old parser would silently
ignore this field, but the new one returned a syntax error.
2015-11-20 10:51:34 -06:00
Paul Hinze
c637ca039c
Merge pull request #3987 from hashicorp/b-aws-test-fixes
...
AWS Test fixtures updates
2015-11-20 10:36:38 -06:00
Paul Hinze
2f25d57e7c
Merge pull request #3993 from lwander/b-gcp-test-ssl-cert
...
provider/google: self-signed ssl certs for testing
2015-11-20 10:36:27 -06:00
Lars Wander
93ff7edb13
provider/google: self-signed ssl certs for testing
2015-11-20 11:32:25 -05:00
Paul Hinze
e67551a641
provider/docker: fix image test
...
there's a new latest in town
2015-11-20 09:58:03 -06:00
Paul Hinze
e9a18a8f9f
provider/google: fix sql database test
...
Was missing a required parameter
/cc @lwander @sparkprime
2015-11-20 09:52:23 -06:00
clint shryock
73475edceb
update TestAccAWSFlowLog_subnet to use new cloudwatch resource, not needing env var anymore
2015-11-20 09:39:43 -06:00
clint shryock
fe204bb291
error test when env var is not supplied
2015-11-20 09:39:17 -06:00
clint shryock
4d0699b9dd
mark snapshots as computed for ElastiCache clusters
2015-11-20 09:39:17 -06:00
Takaaki Furukawa
cb84b98ce4
provider/vsphere: Rename functions
2015-11-20 21:01:02 +09:00
Takaaki Furukawa
7bf02243a1
rename vcenter_server config parameter to something clearer
2015-11-20 20:37:49 +09:00
Paul Hinze
887839ce23
provider/digitalocean: remove relative CNAME test
...
Heard back from DO support:
> we require it to be a FQDN for a CNAME record in our DNS system.
/cc @paystee, the original author here
2015-11-19 18:36:58 -06:00
Paul Hinze
3d089143c6
provider/azure: fix hosted service acctest
...
Just some basic bitrot stuff.
2015-11-19 16:28:24 -06:00
clint shryock
325fd751eb
update TestAccAWSFlowLog_subnet to use new cloudwatch resource, not needing env var anymore
2015-11-19 16:27:56 -06:00
clint shryock
e91381c4e2
error test when env var is not supplied
2015-11-19 16:24:17 -06:00
clint shryock
0aedb7eae6
mark snapshots as computed for ElastiCache clusters
2015-11-19 16:19:53 -06:00
Paul Hinze
75d056c878
provider/digitalocean: comment out test for relative DNS records
...
Until we hear back from DigitalOcean on whether this behavior is
supposed to be supported or not.
2015-11-19 16:11:42 -06:00
clint shryock
bcfbf11120
Merge branch 'master' of github.com:hashicorp/terraform
...
* 'master' of github.com:hashicorp/terraform:
config: test covering escaped quotes syntax error
Add failing tests for JSON configuration parsing
scripts: check for the correct env vars in dist.sh
2015-11-19 15:50:06 -06:00
clint shryock
01b9af40d1
fix resource name in test
2015-11-19 15:44:40 -06:00
clint shryock
0874347478
update ami id for test
2015-11-19 15:37:05 -06:00
Paul Hinze
afb5136ac2
Merge pull request #3986 from hashicorp/phinze/hcl-escaped-quotes
...
config: test covering escaped quotes syntax error
2015-11-19 12:32:30 -06:00
Paul Hinze
15e7927009
config: test covering escaped quotes syntax error
...
This was never intended to be valid syntax, but it worked in the old HCL
parser, and we've found a decent number of examples of it in the wild.
Fixed in https://github.com/hashicorp/hcl/pull/62 and we'll keep this
test in Terraform to cover the behavior.
2015-11-19 12:11:42 -06:00
Paul Hinze
bd8863c994
Merge pull request #3973 from hashicorp/phinze/tweak-dist
...
scripts: check for the correct env vars in dist.sh
2015-11-19 11:03:38 -06:00
James Nugent
15522e80a5
Merge pull request #3984 from hashicorp/b-json-hcl
...
Add tests for JSON configuration parsing
2015-11-19 19:02:26 +02:00
James Nugent
6ae3218f8a
Add failing tests for JSON configuration parsing
...
Reproduces the issue reported by @svanharmelen in #3964 .
2015-11-19 16:06:30 +02:00
Joe Topjian
f9dd42ddce
provider/openstack: Add State Change support to LBaaS Resources
...
This commit adds State Change support to the LBaaS resources which should
help with clean terminations.
It also adds an acceptance tests that builds out a 2-node load balance
service.
2015-11-19 04:33:53 +00:00
Paul Hinze
203a565161
scripts: check for the correct env vars in dist.sh
...
we need AWS keys now, not bintray keys
2015-11-18 17:16:03 -06:00
chrislovecnm
98167cea79
merging upstream master
2015-11-18 16:09:05 -07:00
clint shryock
fd251e8b45
rename TestAccAWSRoute53Record_weighted to TestAccAWSRoute53Record_weighted_basic to test in isolation
2015-11-18 16:08:23 -06:00
Clint
99c4da7851
Update CHANGELOG.md
2015-11-18 13:57:35 -06:00
Clint
5024d66f3c
Merge pull request #3970 from hashicorp/b-aws-iam-policy-attachfix
...
providers/aws: Fix typo in error checking for IAM Policy Attachments
2015-11-18 13:57:03 -06:00
clint shryock
5482e98927
Fix typo in error checking for IAM Policy Attachments
2015-11-18 13:48:46 -06:00
Paul Hinze
a211fc3469
Merge pull request #3965 from hashicorp/b-aws-sg-rules-v2-race
...
provider/aws: serialize SG rule access to fix race condition
2015-11-18 12:47:55 -06:00
Paul Hinze
6b6b5a43c3
provider/aws: serialize SG rule access to fix race condition
...
Because `aws_security_group_rule` resources are an abstraction on top of
Security Groups, they must interact with the AWS Security Group APIs in
a pattern that often results in lots of parallel requests interacting
with the same security group.
We've found that this pattern can trigger race conditions resulting in
inconsistent behavior, including:
* Rules that report as created but don't actually exist on AWS's side
* Rules that show up in AWS but don't register as being created
locally, resulting in follow up attempts to authorize the rule
failing w/ Duplicate errors
Here, we introduce a per-SG mutex that must be held by any security
group before it is allowed to interact with AWS APIs. This protects the
space between `DescribeSecurityGroup` and `Authorize*` / `Revoke*`
calls, ensuring that no other rules interact with the SG during that
span.
The included test exposes the race by applying a security group with
lots of rules, which based on the dependency graph can all be handled in
parallel. This fails most of the time without the new locking behavior.
I've omitted the mutex from `Read`, since it is only called during the
Refresh walk when no changes are being made, meaning a bunch of parallel
`DescribeSecurityGroup` API calls should be consistent in that case.
2015-11-18 12:39:59 -06:00
Brett Mack
815ff7ac63
Merge branch 'terraform' into hmrc
2015-11-18 17:56:28 +00:00
James Nugent
b177370bdc
Merge pull request #3962 from miguelaferreira/patch-1
...
provider/cloudstack docs: use underscore in virtual machine attribute
2015-11-18 17:14:58 +02:00
James Nugent
ce1bcd7ccc
Merge pull request #3959 from chrislovecnm/vsphere-ipv4-documentation-updates
...
Update docs to reflect vsphere provider only supporting IPv4 addresses
2015-11-18 17:11:37 +02:00
James Nugent
0a7e545b55
Merge pull request #3956 from Banno/fix-template-docs
...
docs: fix template_file syntax error
2015-11-18 17:10:15 +02:00
James Nugent
00824d2ea9
Merge pull request #3950 from hashicorp/f-make-core
...
Add `core` target to Makefile
2015-11-18 17:09:05 +02:00
James Nugent
13548fcaa2
Add `core-dev` target to Makefile
...
This is shorthand to build and install the core of terraform, without
touching the providers.
2015-11-18 16:59:58 +02:00
James Nugent
6a74f74ab8
Merge pull request #3961 from aznashwan/b-aws-provider-build
...
provider/aws: remove build-blocking unused variable.
2015-11-18 16:32:48 +02:00