5e0b603212
Merge pull request #4041 from svanharmelen/b-chef-provisioner
...
Revert changing `path.Join()` to `filepath.Join()` (PR #3896 )
2015-11-24 08:44:46 -06:00
b007d4f77a
Revert changing `path.Join()` to `filepath.Join()` (PR #3896 )
...
PR #3896 added support for passing keys by content, but in this same PR
all references to `path.Join()` where changed to `filepath.join()`.
There is however a significant difference between these two calls and
using the latter one now causes issues when running the Chef
provisioner on Windows (see issue #4039 ).
2015-11-24 14:40:46 +01:00
1cde2e64a0
Merge pull request #3748 from stack72/do-floatingips
...
provider/digitalocean : New Resource for Floating IPs
2015-11-24 13:16:24 +02:00
3fc9107333
Using the laterst version of the DO API to get the Assign of an IP working without a time.Sleep
2015-11-24 11:08:43 +00:00
288e568272
Merge pull request #4024 from rjeczalik/nil-deref-fix
...
provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452
2015-11-24 11:52:33 +02:00
9e66e18334
provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452
2015-11-24 09:30:21 +01:00
99e3d62cd8
provider/aws: Make VPC ID required on subnets
2015-11-23 16:53:49 +02:00
82050ff832
Merge pull request #4005 from hashicorp/b-aws-iam-user-delete
...
provider/aws: Fix issue deleting users who are attached to a group
2015-11-23 08:22:48 -06:00
7772a66b2f
Merge pull request #3940 from hashicorp/b-aws-spot-instance-updates
...
providers/aws: Update Spot Instance request to provide connection information
2015-11-23 08:22:07 -06:00
150e997a96
Changing the AWS ElastiCache cluster maintenance_window to enforce lowercase
2015-11-23 12:54:56 +00:00
3809315af9
Upped default maxRetryTimeout from 30s -> 60s
2015-11-23 11:45:16 +00:00
749fcd4931
Merge pull request #4010 from pforman/cloudtrail-enable
...
provider/aws: Add "enable_logging" to CloudTrail resource
2015-11-23 07:59:29 +00:00
52aad04930
Mistake in type refactor in cloudTrailGetLoggingStatus
...
When adjusting the types to prevent casting, I didn't change the error
message to handle the pointer change. "go tool vet" caught this.
2015-11-22 13:23:08 -07:00
9cec40ea3c
Add missing error-checks from code review
...
Some error-checking was omitted.
Specifically, the cloudTrailSetLogging call in the Create function was
ignoring the return and cloudTrailGetLoggingStatus could crash on a
nil-dereference during the return. Fixed both.
Fixed some needless casting in cloudTrailGetLoggingStatus.
Clarified error message in acceptance tests.
Removed needless option from example in docs.
2015-11-22 12:54:11 -07:00
484887c0c5
Change default for logging in CloudTrail to true
...
The default for `enable_logging`, which defines whether CloudTrail
actually logs events was originally written as defaulting to `false`,
since that's how AWS creates trails.
`true` is likely a better default for Terraform users.
Changed the default and updated the docs.
Changed the acceptance tests to verify new default behavior.
2015-11-22 10:47:23 -07:00
774ed1ded8
Merge pull request #4012 from rakutentech/rename-function
...
provider/vsphere: Rename create* functions
2015-11-22 11:34:42 +02:00
c9eeb161e0
Add a comment in tests
...
The purpose of the first test of enable_logging wasn't quite clear.
It's future-proofing against the assumptions made about AWS behavior.
2015-11-21 14:55:08 -07:00
11190144f0
AWS Opsworks tests bring their own IAM objects.
...
Previously we assumed the existence of some default objects that most
Opsworks users have because the Opsworks console creates them by default
when a new stack is created.
However, that meant that these tests wouldn't work correctly for anyone
who either had never used Opsworks via the UI or who had never accepted
the default of having the console create some predefined IAM objects to
use. It may also have led to some weird failures if a particular user had
customized the settings for these default objects.
Now the tests create suitable IAM roles, a policy and an instance profile
and use these when creating Opsworks stacks, avoiding any dependency
on any pre-existing objects.
This fixes #3998 .
2015-11-21 11:13:25 -08:00
f1c2be9772
Make maxRetryTimeout (in seconds) configurable
2015-11-21 12:54:59 +00:00
f98dbbb580
Tests and docs for AWS CloudTrail "enable_logging"
...
Add acceptance tests for creation, enable, and disable logging.
Add option to docs and example.
2015-11-21 00:18:38 -07:00
52db098292
Add enable_logging to AWS CloudTrail
...
The AWS CloudTrail resource is capable of creating CloudTrail resources,
but AWS defaults the actual logging of the trails to `false`, and
Terraform has no method to enable or monitor the status of logging.
CloudTrail trails that are inactive aren't very useful, and it's a
surprise to discover they aren't logging on creation.
Added an `enable_logging` parameter to resource_aws_cloudtrail to enable
logging. This requires some extra API calls, which are wrapped in new
internal functions.
For compatibility with AWS, the default of `enable_logging` is set to
`false`.
2015-11-21 00:18:38 -07:00
233aab6e0a
provider/aws: Fix issue deleting users who are attached to a group
...
If you want to delete an IAM user, that user must not belong to any groups
2015-11-20 16:54:26 -06:00
cc70d25dc5
Merge pull request #3898 from hashicorp/b-aws-elb-iam-cert-delete
...
providers/aws: Retry deleting IAM Server Cert on dependency violation
2015-11-20 14:50:18 -06:00
9edbf6a7fc
Merge pull request #3908 from hashicorp/b-elb-cookie-fix
...
provider/aws: Fix issue with LB Cookie Stickiness and empty expiration period
2015-11-20 14:49:00 -06:00
ed3399593a
Merge pull request #3996 from hashicorp/b-aws-test-fixes
...
Adjustments for AWS Acceptance tests
2015-11-20 13:28:25 -06:00
9eb46c28b2
use a log group resourcE
2015-11-20 13:15:20 -06:00
cf5b32617b
fix vpn gateway refresh/reattach issue
2015-11-20 11:47:10 -06:00
74c93d3a46
Reording the code for the creation of a Floating IP for a droplet. The call to the DO api takes a few seconds to propagate so I had to sacriface some kittens and added a short 10 second sleep
2015-11-20 19:12:31 +02:00
7bda855590
Adding the work to assign a Floating IP to a Droplet
2015-11-20 19:12:31 +02:00
9cf1c2943c
Adding the first pass of the work to get a floatingip assigned to a region
2015-11-20 19:12:30 +02:00
24d15820c1
provider/heroku: fix acc test
...
depends_on requires a list of strings. the old parser would silently
ignore this field, but the new one returned a syntax error.
2015-11-20 10:51:34 -06:00
c637ca039c
Merge pull request #3987 from hashicorp/b-aws-test-fixes
...
AWS Test fixtures updates
2015-11-20 10:36:38 -06:00
2f25d57e7c
Merge pull request #3993 from lwander/b-gcp-test-ssl-cert
...
provider/google: self-signed ssl certs for testing
2015-11-20 10:36:27 -06:00
93ff7edb13
provider/google: self-signed ssl certs for testing
2015-11-20 11:32:25 -05:00
e67551a641
provider/docker: fix image test
...
there's a new latest in town
2015-11-20 09:58:03 -06:00
e9a18a8f9f
provider/google: fix sql database test
...
Was missing a required parameter
/cc @lwander @sparkprime
2015-11-20 09:52:23 -06:00
73475edceb
update TestAccAWSFlowLog_subnet to use new cloudwatch resource, not needing env var anymore
2015-11-20 09:39:43 -06:00
fe204bb291
error test when env var is not supplied
2015-11-20 09:39:17 -06:00
4d0699b9dd
mark snapshots as computed for ElastiCache clusters
2015-11-20 09:39:17 -06:00
cb84b98ce4
provider/vsphere: Rename functions
2015-11-20 21:01:02 +09:00
7bf02243a1
rename vcenter_server config parameter to something clearer
2015-11-20 20:37:49 +09:00
887839ce23
provider/digitalocean: remove relative CNAME test
...
Heard back from DO support:
> we require it to be a FQDN for a CNAME record in our DNS system.
/cc @paystee, the original author here
2015-11-19 18:36:58 -06:00
3d089143c6
provider/azure: fix hosted service acctest
...
Just some basic bitrot stuff.
2015-11-19 16:28:24 -06:00
325fd751eb
update TestAccAWSFlowLog_subnet to use new cloudwatch resource, not needing env var anymore
2015-11-19 16:27:56 -06:00
e91381c4e2
error test when env var is not supplied
2015-11-19 16:24:17 -06:00
0aedb7eae6
mark snapshots as computed for ElastiCache clusters
2015-11-19 16:19:53 -06:00
75d056c878
provider/digitalocean: comment out test for relative DNS records
...
Until we hear back from DigitalOcean on whether this behavior is
supposed to be supported or not.
2015-11-19 16:11:42 -06:00
01b9af40d1
fix resource name in test
2015-11-19 15:44:40 -06:00
0874347478
update ami id for test
2015-11-19 15:37:05 -06:00
f9dd42ddce
provider/openstack: Add State Change support to LBaaS Resources
...
This commit adds State Change support to the LBaaS resources which should
help with clean terminations.
It also adds an acceptance tests that builds out a 2-node load balance
service.
2015-11-19 04:33:53 +00:00
98167cea79
merging upstream master
2015-11-18 16:09:05 -07:00
fd251e8b45
rename TestAccAWSRoute53Record_weighted to TestAccAWSRoute53Record_weighted_basic to test in isolation
2015-11-18 16:08:23 -06:00
5024d66f3c
Merge pull request #3970 from hashicorp/b-aws-iam-policy-attachfix
...
providers/aws: Fix typo in error checking for IAM Policy Attachments
2015-11-18 13:57:03 -06:00
5482e98927
Fix typo in error checking for IAM Policy Attachments
2015-11-18 13:48:46 -06:00
a211fc3469
Merge pull request #3965 from hashicorp/b-aws-sg-rules-v2-race
...
provider/aws: serialize SG rule access to fix race condition
2015-11-18 12:47:55 -06:00
6b6b5a43c3
provider/aws: serialize SG rule access to fix race condition
...
Because `aws_security_group_rule` resources are an abstraction on top of
Security Groups, they must interact with the AWS Security Group APIs in
a pattern that often results in lots of parallel requests interacting
with the same security group.
We've found that this pattern can trigger race conditions resulting in
inconsistent behavior, including:
* Rules that report as created but don't actually exist on AWS's side
* Rules that show up in AWS but don't register as being created
locally, resulting in follow up attempts to authorize the rule
failing w/ Duplicate errors
Here, we introduce a per-SG mutex that must be held by any security
group before it is allowed to interact with AWS APIs. This protects the
space between `DescribeSecurityGroup` and `Authorize*` / `Revoke*`
calls, ensuring that no other rules interact with the SG during that
span.
The included test exposes the race by applying a security group with
lots of rules, which based on the dependency graph can all be handled in
parallel. This fails most of the time without the new locking behavior.
I've omitted the mutex from `Read`, since it is only called during the
Refresh walk when no changes are being made, meaning a bunch of parallel
`DescribeSecurityGroup` API calls should be consistent in that case.
2015-11-18 12:39:59 -06:00
815ff7ac63
Merge branch 'terraform' into hmrc
2015-11-18 17:56:28 +00:00
da8314ce8a
provider/aws: removed build-blocking unused variable.
2015-11-18 15:08:45 +02:00
b0fdf8a032
Fixed failing test
2015-11-18 12:54:18 +00:00
51a2fbd6ae
Merge pull request #3927 from jtopjian/jtopjian-openstack-lbvip-attr-cleanup
...
provider/openstack: Clean up some attributes in LBaaS VIP resource
2015-11-17 20:19:25 -07:00
306046b82b
Merge pull request #3955 from cbusbey/db_subnet_spaces
...
allow spaces in db subnet name
2015-11-17 22:38:36 +00:00
0bd8b32637
Merge pull request #3237 from GrayCoder/group-work
...
provider/aws: add support for group name and path changes with group update function
2015-11-17 16:37:40 -06:00
a5690b7510
removing debug print statements
2015-11-17 22:00:46 +00:00
12d51edeb6
allow spaces in db subnet name
2015-11-17 12:48:56 -08:00
29dfc4322e
Add retry calls to protect against api rate limiting
2015-11-17 17:27:39 +00:00
2ed867b5ab
Merge pull request #3945 from hashicorp/b-aws-r53-record-zone-fix
...
provider/aws: Fix crash in Route53 Record if Zone not found
2015-11-17 09:10:50 -06:00
edaaab9f62
Merge pull request #3948 from pshima/f-packet-net-provisioner-ip
...
Populate the provisioner connection info for packet.net devices
2015-11-17 13:26:10 +00:00
c8dfecc65f
Check where nested structs could possibly be nil before trying to access their data
2015-11-17 11:40:37 +00:00
f140c15039
Fixed null pointer panic during firewall rules test
2015-11-17 10:44:50 +00:00
cc54785b1c
Merge branch 'terraform' into hmrc
2015-11-17 10:13:53 +00:00
e2ef92f50f
Populate the provisioner connection info for packet.net devices with the ipv4 public address
2015-11-16 21:02:57 -08:00
6875e9aaec
Issue #3894 RDS publicly_accessible param shouldn't force new resource
...
Change-Id: I0a10e050ca1c4f2dde5e04f237de6115723522d8
2015-11-16 17:47:35 -08:00
7e59d7f67c
Merge pull request #3901 from hashicorp/phinze/google-credentials
...
provider/google: read credentials as contents instead of path
2015-11-16 17:57:54 -06:00
010293992a
Merge pull request #3899 from hashicorp/phinze/azure-publish-settings
...
provider/azure: read publish_settings as contents instead of path
2015-11-16 17:54:43 -06:00
fb0dc4951d
provider/azure: read publish_settings as contents instead of path
...
Building on the work in #3846 , shifting the Azure provider's
configuration option from `settings_file` to `publish_settings`.
2015-11-16 17:47:56 -06:00
00d0551933
aws: Add missing dereference operator
2015-11-16 23:19:45 +00:00
1413d032ee
provider/aws: Fix crash in Route53 Record if Zone not found
2015-11-16 17:15:17 -06:00
901e5fbf9f
fix log reference
2015-11-16 17:14:02 -06:00
8085e55eda
fix issue with undefined var
2015-11-16 16:29:52 -06:00
a8ceda1b15
Merge pull request #3914 from TimeIncOSS/b-aws-ecs-service-gone
...
provider/aws: Prevent crashing when deleting ecs_service which is gone
2015-11-16 21:46:06 +00:00
70f1c9c1e6
remove duplicate readInstance call
2015-11-16 15:16:41 -06:00
eb9a93862b
provider/google: read credentials as contents instead of path
...
Building on the work in #3846 , shifting the Google provider's
configuration option from `account_file` to `credentials`.
2015-11-16 15:14:32 -06:00
66ad974193
add acceptance test for spot instanace updates
2015-11-16 15:11:44 -06:00
f31b30d4a5
minor tweaks to connection info setup
2015-11-16 14:51:14 -06:00
993ec0a320
Merge pull request #3909 from hashicorp/phinze/template-file-contents
...
template_file: source contents instead of path
2015-11-16 14:50:45 -06:00
0cdc81f390
Merge pull request #3896 from hashicorp/phinze/chef-keys-as-contents
...
chef: read key contents instead of paths
2015-11-16 21:44:09 +01:00
d998e883fb
providers/aws: Update Spot Instance request to provide connection information
2015-11-16 14:43:24 -06:00
ecc4ce3657
Converted firewall_rules rule set to a list type. Code tidy
2015-11-16 20:11:05 +00:00
afb416fba4
Merge pull request #2807 from dwradcliffe/f-dyn-provider
...
add Dyn provider
2015-11-16 13:53:44 -06:00
5c59bd95cb
Merge pull request #3924 from TimeIncOSS/b-aws-ecs-td-computed
...
provider/aws: Make all fields in ecs_task_definition ForceNew
2015-11-16 15:31:17 +00:00
309e697a52
provider/tls: add locally signed certificates
...
This allows you to generate and sign certificates using a local CA.
2015-11-15 20:23:40 -05:00
4f25b552bb
use single import path for aws-sdk-go
2015-11-16 00:42:08 +01:00
b4242e6f35
provider/openstack: Clean up some attributes in LBaaS VIP resource
...
This commit makes a few attributes computed so the generated information
is accessible after creation.
It also fixes the "persistence" attribute, which previously had a typo.
Finally, it converts "admin_state_up" to a Boolean to match the majority
of other attributes of the same name.
2015-11-14 21:16:23 +00:00
33ca2a796f
Fix typo (Modifier -> Modified)
2015-11-14 12:19:29 +00:00
308edd6dd7
provider/aws: Make all fields in ecs_task_definition ForceNew
...
- fixes https://github.com/hashicorp/terraform/issues/2694
2015-11-14 10:36:01 +00:00
aae8fc8494
provider/aws: Add acceptance test for bugfix for #2694
2015-11-14 10:34:17 +00:00
d5ae5ba062
Merge pull request #3910 from hashicorp/phinze/s3-object-homedir-expand
...
provider/aws: homedir expand in s3 object source
2015-11-14 09:35:09 +00:00
e7c88eab35
openstack: fix go vet error (bool modifier is %t)
2015-11-14 08:19:22 +00:00
19fc2193f4
Merge pull request #3904 from jtopjian/jtopjian-openstack-port-attr-cleanup
...
provider/openstack: Make Networking Port attributes more intuitive
2015-11-13 20:15:29 -07:00
f2a5064538
Merge pull request #3857 from jtopjian/jtopjian-openstack-secgroup-rule-fix2
...
provider/openstack: Security Group Rule fixes
2015-11-13 20:13:46 -07:00
Paul Hinze