Commit Graph

5216 Commits

Author SHA1 Message Date
Christopher Tiwald 2252b83d9a Fix three trivial errors 'go vet' discovered. 2015-05-13 21:23:07 -04:00
Paul Hinze f0e6d0f97e docs: fix cidr_block on aws SG egress
fixes #1936
2015-05-13 18:41:41 -05:00
Paul Hinze c435e3efb6 Merge pull request #1953 from hashicorp/b-no-roots-found
core: respect roots in CBD transform
2015-05-13 17:57:31 -05:00
Paul Hinze 842d66183b core: respect roots in CBD transform
Because CBD now runs after a RootTransformer, it's now operating on a
graph that _may_ have had a graphNodeRoot added to it (a noop node whose
only purpose is to be a root).

CBD includes a step that tells the destroy node to depend on any parents
of the create node. When one of those parents was "root", this was
causing the destroy node to depend on "root", making it cease to be an
actual root node.

Because graphNodeRoot is a singleton, the follow-up RootTransformer was
not sufficient to slap another root on top - it wasn't being seen as a
fresh node, so edges were just accumulating, and we ended up in a state
with "no roots".

refs #1903 (not sure if this will fix all the "no root found" cases, or
just the one I bumped into)
2015-05-13 17:53:42 -05:00
Paul Hinze e1b4bf3ce0 Merge pull request #1949 from hashicorp/b-module-cbd-computed-count-deadlock
core: fix deadlock w/ CBD + modules
2015-05-13 13:24:00 -05:00
Paul Hinze b0eafeb212 core: fix deadlock w/ CBD + modules
fixes #1947

Root cause was a bad edge being made by the CBD transform going from the
flattened destroy node to the unflattened create node, which was no
longer in the graph. The destroy node therefore had a dependency that
could never be satisfied, which locked up the walk.
2015-05-13 13:05:43 -05:00
Paul Hinze 725f66796b Merge pull request #1944 from hashicorp/b-flatten-orphan-modules
core: flatten orphan modules
2015-05-13 11:57:58 -05:00
Paul Hinze 63241c991b core: flatten disabled providers 2015-05-13 11:50:11 -05:00
Paul Hinze a5e4e3de59 core: flatten orphan modules 2015-05-13 11:33:29 -05:00
Radek Simko c003e9690f Merge pull request #1941 from uzyexe/fix_missing_resource_name_iam_group_policy
Missing "aws_" in website docs for aws_iam_group_policy
2015-05-13 10:25:06 +01:00
uzyexe 2043698819 missing is "aws_" 2015-05-13 17:17:33 +09:00
Radek Simko 8cb2063474 update CHANGELOG 2015-05-13 07:44:31 +01:00
Radek Simko 5d6eff03be Merge pull request #1829 from josharian/formatlist
config: add formatlist
2015-05-13 07:35:56 +01:00
Clint Shryock 898fa91595 network acl cleanups 2015-05-12 22:23:55 -05:00
Josh Bleecher Snyder 02e751e356 config: add formatlist
formatlist distributes formatting over lists.
See the docs for details.

As a colleague commented:

"It happens all the time that we want a set of
outputs, but in a slightly different way than
just simple joining or concatting."

formatlist (combined with join)
makes it easy to satisfy those needs.
2015-05-12 16:11:42 -07:00
Josh Bleecher Snyder a3f79cd790 config: fix minor comment errors 2015-05-12 16:11:19 -07:00
Sander van Harmelen 75f000e0cc Merge pull request #1937 from svanharmelen/update-changelog
Adding Chef provisioner info to the CHANGELOG
2015-05-12 23:59:59 +02:00
Sander van Harmelen 57666d4233 Adding Chef provisioner info to the CHANGELOG 2015-05-12 23:56:32 +02:00
Radek Simko a4c9dd6271 Merge pull request #1935 from TimeIncOSS/iam_role_docs
Add docs for aws_iam_role + clean up examples in IAM docs
2015-05-12 22:50:32 +01:00
Radek Simko 0c07fa359b Add missing EOF to iam_role_policy example 2015-05-12 22:29:36 +01:00
Radek Simko b5f0dc867b Fix incorrect parameter name 2015-05-12 22:29:36 +01:00
Radek Simko c214130401 aws: Reorder resources in IAM examples in docs
- This is to make relevant resources more visible
2015-05-12 22:29:36 +01:00
Radek Simko f24e8c7b53 Add docs for aws_iam_role 2015-05-12 22:29:35 +01:00
Sander van Harmelen 4e0aa334fa Merge pull request #1868 from svanharmelen/f-chef-client-provisioner
New provisioner for Chef-Client
2015-05-12 23:06:09 +02:00
Clint c7a6a4f232 Merge pull request #1933 from hashicorp/f-aws-remove-sdk-suffix
Strip 'sdk' suffix from methods; it's a remnant
2015-05-12 15:57:30 -05:00
Paul Hinze bb3ed8d740 Merge pull request #1934 from hashicorp/b-flatten-orphan-outputs
core: flatten orphan outputs
2015-05-12 15:14:08 -05:00
Paul Hinze 9c7fb87ca8 core: flatten orphan outputs
Hit the "unflattenable node" error again with these.

This fixes it.
2015-05-12 15:10:21 -05:00
Clint Shryock f7b6b6b2b5 Strip 'sdk' suffix from methods; it's a remnant 2015-05-12 14:58:10 -05:00
Dave Cunningham b4d0f71b32 Update CHANGELOG 2015-05-12 15:51:35 -04:00
Dave Cunningham 372908cc6f Merge pull request #980 from BashtonLtd/gce_instance_template_network_update
Update Instance Template network definition to match changes to Instance.
2015-05-12 15:46:04 -04:00
Paul Hinze 4ed0a6eca0 Merge pull request #1932 from hashicorp/f-aws-api-coverage-script
contrib: aws api coverage report script
2015-05-12 14:33:39 -05:00
Paul Hinze 2d1aafd549 contrib: aws api coverage report script
quick 'n' dirty - might have some bugs, but it'll get us started
2015-05-12 14:16:22 -05:00
Clint Shryock 0dda704cbf provider/aws: Support multiple subnets in Network ACL 2015-05-12 13:50:28 -05:00
Dave Cunningham 6835009238 Update CHANGELOG 2015-05-12 13:06:02 -04:00
Mitchell Hashimoto e5ca0cc7c5 update CHANGELOG 2015-05-12 09:35:02 -07:00
Mitchell Hashimoto 251f7919b3 Merge pull request #1922 from hashicorp/b-orphans-in-module-unflattenable
core: make orphans flattenable
2015-05-12 09:34:37 -07:00
Dave Cunningham e27393af41 Merge pull request #1894 from dcarley/gce_health_check_defaults
provider/gce: Fix updates for http_health_check (set defaults)
2015-05-12 12:29:40 -04:00
Mitchell Hashimoto 130aeda8b4 Merge pull request #1928 from uzyexe/fix_typo_propagating_vgws_document
Typo in website docs for aws_route_table
2015-05-12 09:25:22 -07:00
uzyexe b16b5e4a8c Typo in website docs for aws_route_table 2015-05-13 01:13:02 +09:00
Justin Campbell b8cd6b2bae providers/aws: Add support for S3 website redirect 2015-05-12 11:24:08 -04:00
Justin Campbell 969b77933f Merge pull request #1926 from hashicorp/b-validate-confictswith-against-top-schema-map
helper/schema: validate ConflictsWith against top-level
2015-05-12 11:23:50 -04:00
Justin Campbell bb14bfa657 helper/schema: call InternalValidate w/ schemaMap{} 2015-05-12 11:01:08 -04:00
Paul Hinze 1e3d1b07e6 helper/schema: validate ConflictsWith against top-level
The runtime impl of ConfictsWith uses Resource.Get(), which makes it
work with any other attribute of the resource - the InternalValidate was
only checking against the local schemaMap though, preventing subResource
from using ConflictsWith properly.

It's a lot of wiring and it's a bit ugly, but it's not runtime code, so
I'm a bit less concerned about that aspect.

This should take care of the problem mentioned in #1909
2015-05-12 09:45:15 -05:00
Sander van Harmelen 11314a3d71 Tweaking a few minor things according to the feedback on GH 2015-05-12 10:37:38 +02:00
Radek Simko 931d05198c Merge pull request #1886 from TimeIncOSS/subnet-timeout-fix
Increase subnet & security group deletion timeout (2 -> 5 mins)
2015-05-12 07:02:28 +01:00
Paul Hinze 0273732dec core: make orphans flattenable
Got this while playing around in a module:

> * unflattenable node: aws_security_group.internal (orphan)
> *terraform.graphNodeOrphanResource

Basically just copied implementation from
d503cc2d82
2015-05-11 22:24:11 -05:00
Dave Cunningham a2cadbb5c1 Merge pull request #1920 from sparkprime/allow-local-ssd-pr
Allow local SSDs, Fix #1088
2015-05-11 23:06:12 -04:00
Dave Cunningham 5f15a9d26a Allow local SSDs, Fix #1088 2015-05-11 21:40:37 -04:00
Mitchell Hashimoto cb0374a7e3 update CHANGELOG 2015-05-11 16:38:17 -07:00
Mitchell Hashimoto e1627883b2 Merge pull request #1907 from PeopleNet/rds-update
provider/aws: Closes #1906. Only submit modification requests if there is a change
2015-05-11 16:38:02 -07:00