Commit Graph

18015 Commits

Author SHA1 Message Date
Tom Harvey 6f2551ec33 Merge pull request #12455 from brandontosch/brandontosch/GH-11874
AzureRM Managed Disks
2017-04-06 10:29:40 +01:00
Nic Jackson b908fc54dc
Updated provider documentation to highlight limitations of interpolation syntax 2017-04-06 09:19:37 +01:00
Alan D. Salewski a2c63613eb fixes #13405: website (typo): "will automatic lock" ==> "will automatically lock" 2017-04-05 18:23:17 -07:00
= 1f13ff22a3 TestAccAWSAutoScalingGroup_ALB_TargetGroups passes 2017-04-05 16:07:14 -06:00
James Bardin e2a428b43f Merge pull request #13384 from hashicorp/s3-state-locks
Unify s3 client code
2017-04-05 16:15:08 -04:00
Clint 092fe7ded6 Merge pull request #13394 from hashicorp/b-aws-redshift-fixes
provider/aws: Fix some Acc tests by skipping final snaphot in Redshift
2017-04-05 15:08:21 -05:00
Clint c3d34b2c6e Update CHANGELOG.md 2017-04-05 14:39:24 -05:00
Clint 7cd0708402 Merge pull request #13281 from ameir/fix-aws_s3_bucket-logging-diff
Fix `aws_s3_bucket` diff of logging options
2017-04-05 14:38:39 -05:00
clint shryock 053dd92937 provider/aws: Fix some Acc tests by skipping final snaphot in Redshift
Redshift was changed to not skip snapshots by default, so our configs
were out of date and causing errors in destroy (thus leaking redshifts)

This changes the configs to skip snapshots, which should at least fix:

- TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates
- TestAccAWSRedshiftCluster_loggingEnabled
2017-04-05 14:33:33 -05:00
Colin Wood 10cda98245 Refactoring of bitbucket provider with betters.
Also doesnt use decode/encode anymore since those methods are more
intended for streams. So this goes to the more standed marshal/unmarshal
of data.

This also adds better error support and will try to give the user
better errors from the api if it can. Or any issues with the bitbucket
service.
2017-04-05 12:09:43 -07:00
clint shryock 95c58269b9 provider/aws: fix TestAccAWSCloudwatchLogSubscriptionFilter_basic by linking the name 2017-04-05 13:48:13 -05:00
clint shryock 403e48f1cf provider/aws: Randomize ElastiCache param group name. Fixes TestAccAWSElasticacheParameterGroupOnly,
TestAccAWSElasticacheParameterGroup_basic, TestAccAWSElasticacheParameterGroup_importBasic
2017-04-05 13:01:17 -05:00
Clint 114856ec9a Update CHANGELOG.md 2017-04-05 12:48:44 -05:00
Clint 66124fb343 provider/aws: Fix KMS Key reading with Exists method (#13348)
* provider/aws: Fix KMS Key reading with Exists method

Fixes #13322 by checking if the key Exists and offering to recreate if
not found, or pending delete

* remove redundant code
2017-04-05 12:48:11 -05:00
James Bardin 6e136c848a use the aws provider client initialization
Use the aws provider code to create the clients for the s3 backend, so
that all the behavior matches that of the provider.

Remove the fake creds from the test, as the aws provider will attempt to
validate them.
2017-04-05 12:39:50 -04:00
Martin Atkins 1eb744c6cf website: clarify some aspects of the aws_lambda_function docs
The docs on aws_lambda_function used some differing terminology to
what's currently used in the official AWS lambda docs, which
caused some confusion for users trying to use the Java runtime
where the "deployment package" is a JAR archive rather than a plain
zip file.

This change attempts to be consistent with the terminology used in the
AWS docs and also clarifies that the implementation now allows
source_code_hash to be used regardless of which deployment package
upload method is in use.

This fixes #12443.
2017-04-05 09:33:03 -07:00
Paul Stack 4a804db415 Update CHANGELOG.md 2017-04-05 19:29:32 +03:00
James Bardin 0ec2a5cfd3 add AWSClient methods to get s3 and dyndb conns
Add getters for the AWSClient s3.S3 and dynamodb.DynamoDB clients so the
s3 remote-state backend can use all the same initialization code as the
aws provider.
2017-04-05 12:29:25 -04:00
Paul Stack 6d9384aeeb provider/aws: Add support for evaluate_low_sample_count_percentiles to cloudwatch_metric_alarm (#13371)
```

```
2017-04-05 19:28:57 +03:00
= e2a1f5e25e Fixed TestAccAWSEcsDataSource_ecsTaskDefinition 2017-04-05 09:07:49 -06:00
Sander van Harmelen 815c085b8f Update CHANGELOG.md 2017-04-05 15:37:47 +02:00
Joakim Sernbrant b608f0beca provider/cloudstack: do not force a new resource when updating load balancer members (#11786) 2017-04-05 15:34:35 +02:00
James Bardin eeddc3f8ea add some nil checks for unexpected lock failures 2017-04-05 09:06:47 -04:00
Paul Stack c3bfbe6756 Update CHANGELOG.md 2017-04-05 15:18:19 +03:00
Paul Stack d938d263f6 provider/aws: Add support for treat_missing_data to cloudwatch_metric_alarm (#13358)
* provider/aws: Add support for treat_missing_data to cloudwatch_metric_alarm

Fixes: #13263

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/05 08:51:06 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCloudWatchMetricAlarm -timeout 120m
=== RUN   TestAccAWSCloudWatchMetricAlarm_importBasic
--- PASS: TestAccAWSCloudWatchMetricAlarm_importBasic (23.93s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_basic
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (27.81s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_treatMissingData
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (43.39s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_extendedStatistic
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (26.80s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_missingStatistic
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (5.95s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	127.899s
```

* provider/aws: Set cloudwatch_metric_alarm treamt_missing_data to missing

This follows what the AWS API does. We had to add a state migration for
this to make sure that the user doesn't see any unexpected activity on
their Terraform plans

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAWSCloudWatchMetricAlarmMigrateState'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/05 14:51:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAWSCloudWatchMetricAlarmMigrateState -timeout 120m
=== RUN   TestAWSCloudWatchMetricAlarmMigrateState
2017/04/05 14:52:13 [INFO] Found AWS CloudWatch Metric Alarm State v0; migrating to v1
2017/04/05 14:52:13 [DEBUG] Attributes before migration: map[string]string{}
2017/04/05 14:52:13 [DEBUG] Attributes after migration: map[string]string{"treat_missing_data":"missing"}
--- PASS: TestAWSCloudWatchMetricAlarmMigrateState (0.00s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	0.018s
```
2017-04-05 13:17:47 +01:00
Radek Simko 2dbde462fe Update CHANGELOG.md 2017-04-05 13:15:09 +01:00
Radek Simko cd79471ecb provider/aws: Increase Beanstalk 'ready' timeout (#13359) 2017-04-05 13:11:55 +01:00
Radek Simko 0bab530de2 Update CHANGELOG.md 2017-04-05 13:11:30 +01:00
Radek Simko affce99a8e provider/aws: Increase launch_configuration creation timeout (#13357) 2017-04-05 13:10:46 +01:00
Radek Simko ed5acac2b7 Update CHANGELOG.md 2017-04-05 13:10:25 +01:00
Radek Simko 77150880e0 provider/aws: Increase subnet deletion timeout (#13356) 2017-04-05 13:09:44 +01:00
Radek Simko 1c0cd0dd8f provider/aws: Fix wrong config in ES domain acceptance test (#13362) 2017-04-05 12:27:56 +01:00
Ringo De Smet 9ce2b12ec9 Document the `environment` attribute. (#13360)
The existence of the attribute is mentioned here already: https://www.terraform.io/docs/state/environments.html
2017-04-05 09:53:18 +01:00
Paul Stack 98623ecaed provider/aws: Bump SDK version to 1.8.8 (#13354) 2017-04-05 08:45:27 +01:00
Paul Stack 71c92fcc3f Update CHANGELOG.md 2017-04-05 06:49:58 +01:00
Paul Stack 5cad27bb2e provider/aws: Migrate aws_dms_* resources away from AWS waiters (#13291)
The AWS waiter package has changed location in the 1.8.0 version of the
SDK. DMS will need to mitigate a breaking change because of this

Between @radeksimko and myself, we think that we should migrate the DMS
resources to using the Terraform state refresh func pattern that is used
across the entire of the AWS provider. DMS is the *only* resource that
currently uses the AWS waiters, so the LOE to migrate is pretty low
2017-04-05 06:48:37 +01:00
Paul Stack a58aff4a0e Update CHANGELOG.md 2017-04-05 06:44:32 +01:00
dannytrigo 92cda8f75d Do not error if compute volume attachment is missing (#13342)
https://github.com/hashicorp/terraform/issues/13334
2017-04-05 06:43:16 +01:00
Brandon Galbraith d310670550 Specify that only elastic load balancers can be defined for `load_balancers` (#13344) 2017-04-04 17:03:20 -05:00
Jake Champlin cc872f9132 Update CHANGELOG.md 2017-04-04 17:04:36 -04:00
Jake Champlin 74a53f71b1 Merge pull request #13261 from harijayms/whiskeyjay/9198fix
provider/azurerm: Fixing crash when importing Local Network Gateways #13301
2017-04-04 17:03:10 -04:00
James Bardin 37e2c23eb9 Merge pull request #13222 from hashicorp/jbardin/init-locks
Fix some backend locking issues
2017-04-04 16:53:21 -04:00
Martin Atkins f57cf5cc05 website: note that destroy provisioners can't run if resource removed
This addresses (via documentation) the issue raised in #13097.
2017-04-04 13:37:37 -07:00
Jake Champlin fed7b6e781 Merge pull request #13129 from tombuildsstuff/validation
provider/azurerm: Moving Reused JSON Validation -> Core
2017-04-04 16:11:13 -04:00
KensoDev 8ac077022e some comments explaining the reason 2017-04-04 13:02:05 -07:00
KensoDev 169afb2351 tag params as optional based on ELB type 2017-04-04 13:00:08 -07:00
Martin Atkins 9f9fac58e0 Update CHANGELOG.md 2017-04-04 12:17:20 -07:00
Martin Atkins 28d6d913e4 core: basic test of EvalVariableBlock
This previously lacked tests altogether. This new test verifies the
"happy path", ensuring that both literal and computed values pass through
correctly into the VariableValues map.
2017-04-04 12:16:19 -07:00
Martin Atkins c1c5c9a2f6 core: fix crash when computed nested map given in module block
This crash resulted because the type switch checked for either of two
types but the type assertion within it assumed only one of them.

A straightforward (if inelegant) fix is to simply duplicate the relevant
case block and change the type assertion, thus allowing the types to match
up in all cases.

This fixes #13297.
2017-04-04 12:16:19 -07:00
James Bardin fb4a365d12 noop migrate copy, add -lock and -input
A couple commits got rebased together here, and it's easier to enumerate
them in a single commit.

Skip copying of states during migration if they are the same state. This
can happen when trying to reconfigure a backend's options, or if the
state was manually transferred. This can fail unexpectedly with locking
enabled.

Honor the `-input` flag for all confirmations (the new test hit some
more). Also unify where we reference the Meta.forceInitCopy and transfer
the value to the existing backendMigrateOpts.force field.
2017-04-04 14:54:48 -04:00