Commit Graph

10 Commits

Author SHA1 Message Date
Paul Hinze 108ccf0007 builtin: Refactor resource.Retry to clarify return
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.

Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.

This makes it eminently clear whether or not a given error is
retryable from inside the client code.

Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
Paul Hinze de656942ae provider/aws: Fix all pointer RetryError returns
All of these RetryErrors were meant to fail right away, but instead
caused retry looping because the typecheck in the implementation of
`resource.Retry()` only catches the value type, and not the pointer
type.

Refs #5537
2016-03-09 14:59:55 -06:00
stack72 e87d3bb711 Enabled Enhanced Monitoring for RDS 2016-02-03 00:14:24 +00:00
clint shryock 5482e98927 Fix typo in error checking for IAM Policy Attachments 2015-11-18 13:48:46 -06:00
Clint Shryock 0c2f189d08 provider/aws: Update to aws-sdk 0.9.0 rc1 2015-08-17 13:27:16 -05:00
Clint Shryock c1daf23a5d provider/aws: Fix issues with TestAccAWSPolicyAttachment_basic 2015-08-06 09:47:35 -05:00
Patrick Gray 28506c3750 add composeErrors function to only expose errors that happened 2015-06-28 22:30:54 -04:00
Patrick Gray 0f5c9c012d check length of slices instead of using incorrect type 2015-06-28 20:00:55 -04:00
Patrick Gray c375a72f15 check for empty string instead of nil 2015-06-28 19:39:50 -04:00
Patrick Gray 3266c44b83 rename to more intuitive name and finish tests 2015-06-18 10:53:52 -04:00