ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Standardize on log level "WARN" rather than "WARNING"

This commit is contained in:
Masayuki Morita 2018-01-17 11:05:26 +09:00 committed by Martin Atkins
parent 0e69f1542d
commit f440dba137
9 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
backend/remote-state/s3/client.go
View File

@ -71,9 +71,9 @@ func (c *RemoteClient) Get() (payload *remote.Payload, err error) {
// verify that this state is what we expect // verify that this state is what we expect
if expected, err := c.getMD5(); err != nil { if expected, err := c.getMD5(); err != nil {
log.Printf("[WARNING] failed to fetch state md5: %s", err) log.Printf("[WARN] failed to fetch state md5: %s", err)
} else if len(expected) > 0 && !bytes.Equal(expected, digest) { } else if len(expected) > 0 && !bytes.Equal(expected, digest) {
log.Printf("[WARNING] state md5 mismatch: expected '%x', got '%x'", expected, digest) log.Printf("[WARN] state md5 mismatch: expected '%x', got '%x'", expected, digest)
if testChecksumHook != nil { if testChecksumHook != nil {
testChecksumHook() testChecksumHook()
@ -312,7 +312,7 @@ func (c *RemoteClient) putMD5(sum []byte) error {
} }
_, err := c.dynClient.PutItem(putParams) _, err := c.dynClient.PutItem(putParams)
if err != nil { if err != nil {
log.Printf("[WARNING] failed to record state serial in dynamodb: %s", err) log.Printf("[WARN] failed to record state serial in dynamodb: %s", err)
} }
return nil return nil

2
builtin/provisioners/chef/resource_provisioner.go
View File

@ -436,7 +436,7 @@ func (p *provisioner) deployConfigFiles(o terraform.UIOutput, comm communicator.
// Check if the run_list was also in the attributes and if so log a warning // Check if the run_list was also in the attributes and if so log a warning
// that it will be overwritten with the value of the run_list argument. // that it will be overwritten with the value of the run_list argument.
if _, found := fb["run_list"]; found { if _, found := fb["run_list"]; found {
log.Printf("[WARNING] Found a 'run_list' specified in the configured attributes! " + log.Printf("[WARN] Found a 'run_list' specified in the configured attributes! " +
"This value will be overwritten by the value of the `run_list` argument!") "This value will be overwritten by the value of the `run_list` argument!")
} }

2
command/meta_backend.go
View File

@ -190,7 +190,7 @@ func (m *Meta) backendConfig(opts *BackendOpts) (*config.Backend, error) {
return nil, nil return nil, nil
} }
log.Println("[WARNING] BackendOpts.Config not set, but config found") log.Println("[WARN] BackendOpts.Config not set, but config found")
opts.Config = conf opts.Config = conf
} }

4
command/plugins_lock.go
View File

@ -45,7 +45,7 @@ func (pf *pluginSHA256LockFile) Read() map[string][]byte {
err = json.Unmarshal(buf, &strDigests) err = json.Unmarshal(buf, &strDigests)
if err != nil { if err != nil {
// This should never happen unless the user directly edits the file. // This should never happen unless the user directly edits the file.
log.Printf("[WARNING] Plugin lock file %s failed to parse as JSON: %s", pf.Filename, err) log.Printf("[WARN] Plugin lock file %s failed to parse as JSON: %s", pf.Filename, err)
return digests return digests
} }
@ -56,7 +56,7 @@ func (pf *pluginSHA256LockFile) Read() map[string][]byte {
digests[name] = digest digests[name] = digest
} else { } else {
// This should never happen unless the user directly edits the file. // This should never happen unless the user directly edits the file.
log.Printf("[WARNING] Plugin lock file %s has invalid digest for %q", pf.Filename, name) log.Printf("[WARN] Plugin lock file %s has invalid digest for %q", pf.Filename, name)
} }
} }

2
plugin/discovery/find.go
View File

@ -95,7 +95,7 @@ func findPluginPaths(kind string, dirs []string) []string {
continue continue
} }
log.Printf("[WARNING] found legacy %s %q", kind, fullName) log.Printf("[WARN] found legacy %s %q", kind, fullName)
ret = append(ret, filepath.Clean(absPath)) ret = append(ret, filepath.Clean(absPath))
} }

2
plugin/discovery/get.go
View File

@ -369,7 +369,7 @@ func checkPlugin(url string, pluginProtocolVersion uint) bool {
if proto == "" { if proto == "" {
// The header isn't present, but we don't make this error fatal since // The header isn't present, but we don't make this error fatal since
// the latest version will probably work. // the latest version will probably work.
log.Printf("[WARNING] missing %s from: %s", protocolVersionHeader, url) log.Printf("[WARN] missing %s from: %s", protocolVersionHeader, url)
return true return true
} }

2
registry/client.go
View File

@ -140,7 +140,7 @@ func (c *Client) addRequestCreds(host svchost.Hostname, req *http.Request) {
creds, err := c.creds.ForHost(host) creds, err := c.creds.ForHost(host)
if err != nil { if err != nil {
log.Printf("[WARNING] Failed to get credentials for %s: %s (ignoring)", host, err) log.Printf("[WARN] Failed to get credentials for %s: %s (ignoring)", host, err)
return return
} }

14
svchost/disco/disco.go
View File

@ -158,7 +158,7 @@ func (d *Disco) discover(host svchost.Hostname) Host {
creds.PrepareRequest(req) // alters req to include credentials creds.PrepareRequest(req) // alters req to include credentials
} }
} else { } else {
log.Printf("[WARNING] Failed to get credentials for %s: %s (ignoring)", host, err) log.Printf("[WARN] Failed to get credentials for %s: %s (ignoring)", host, err)
} }
} }
@ -170,11 +170,11 @@ func (d *Disco) discover(host svchost.Hostname) Host {
resp, err := client.Do(req) resp, err := client.Do(req)
if err != nil { if err != nil {
log.Printf("[WARNING] Failed to request discovery document: %s", err) log.Printf("[WARN] Failed to request discovery document: %s", err)
return ret // empty return ret // empty
} }
if resp.StatusCode != 200 { if resp.StatusCode != 200 {
log.Printf("[WARNING] Failed to request discovery document: %s", resp.Status) log.Printf("[WARN] Failed to request discovery document: %s", resp.Status)
return ret // empty return ret // empty
} }
@ -185,7 +185,7 @@ func (d *Disco) discover(host svchost.Hostname) Host {
contentType := resp.Header.Get("Content-Type") contentType := resp.Header.Get("Content-Type")
mediaType, _, err := mime.ParseMediaType(contentType) mediaType, _, err := mime.ParseMediaType(contentType)
if err != nil { if err != nil {
log.Printf("[WARNING] Discovery URL has malformed Content-Type %q", contentType) log.Printf("[WARN] Discovery URL has malformed Content-Type %q", contentType)
return ret // empty return ret // empty
} }
if mediaType != "application/json" { if mediaType != "application/json" {
@ -197,7 +197,7 @@ func (d *Disco) discover(host svchost.Hostname) Host {
if resp.ContentLength > maxDiscoDocBytes { if resp.ContentLength > maxDiscoDocBytes {
// Size limit here is not a contractual requirement and so we may // Size limit here is not a contractual requirement and so we may
// adjust it over time if we find a different limit is warranted. // adjust it over time if we find a different limit is warranted.
log.Printf("[WARNING] Discovery doc response is too large (got %d bytes; limit %d)", resp.ContentLength, maxDiscoDocBytes) log.Printf("[WARN] Discovery doc response is too large (got %d bytes; limit %d)", resp.ContentLength, maxDiscoDocBytes)
return ret // empty return ret // empty
} }
@ -208,14 +208,14 @@ func (d *Disco) discover(host svchost.Hostname) Host {
servicesBytes, err := ioutil.ReadAll(lr) servicesBytes, err := ioutil.ReadAll(lr)
if err != nil { if err != nil {
log.Printf("[WARNING] Error reading discovery document body: %s", err) log.Printf("[WARN] Error reading discovery document body: %s", err)
return ret // empty return ret // empty
} }
var services map[string]interface{} var services map[string]interface{}
err = json.Unmarshal(servicesBytes, &services) err = json.Unmarshal(servicesBytes, &services)
if err != nil { if err != nil {
log.Printf("[WARNING] Failed to decode discovery document as a JSON object: %s", err) log.Printf("[WARN] Failed to decode discovery document as a JSON object: %s", err)
return ret // empty return ret // empty
} }

2
terraform/plan.go
View File

@ -117,7 +117,7 @@ func (p *Plan) contextOpts(base *ContextOpts) (*ContextOpts, error) {
// the state, there is little chance that these aren't actually equal. // the state, there is little chance that these aren't actually equal.
// Log the error condition for reference, but continue with the state // Log the error condition for reference, but continue with the state
// we have. // we have.
log.Println("[WARNING] Plan state and ContextOpts state are not equal") log.Println("[WARN] Plan state and ContextOpts state are not equal")
} }
thisVersion := version.String() thisVersion := version.String()