ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core: Don't panic if ApplyResourceChange returns invalid new value 

The provider is allowed to return a partial result if it also includes
error diagnostics. Real providers still return at least a null value in
that case due to the RPC format, but test mocks are often more sloppy.
This commit is contained in:
Martin Atkins 2018-09-06 16:53:46 -07:00
parent 84102170b3
commit ee49be73be
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
terraform/eval_apply.go
View File

@ -76,6 +76,13 @@ func (n *EvalApply) Eval(ctx EvalContext) (interface{}, error) {
// incomplete. // incomplete.
newVal := resp.NewState newVal := resp.NewState
// newVal should never be cty.NilVal in a real case, but it can happen
// sometimes in sloppy mocks in tests where error diagnostics are returned
// and the mock implementation doesn't populate the value at all.
if newVal == cty.NilVal {
newVal = cty.NullVal(schema.ImpliedType())
}
for _, err := range newVal.Type().TestConformance(schema.ImpliedType()) { for _, err := range newVal.Type().TestConformance(schema.ImpliedType()) {
diags = diags.Append(tfdiags.Sourceless( diags = diags.Append(tfdiags.Sourceless(
tfdiags.Error, tfdiags.Error,