Use build-in method to get user homedir instead of eval on sh

This commit is contained in:
Paweł Socha 2018-03-21 14:55:56 +01:00
parent 38e6309f03
commit e4b0a989f3
1 changed files with 6 additions and 11 deletions

View File

@ -3,12 +3,10 @@
package main
import (
"bytes"
"errors"
"os"
"os/exec"
"os/user"
"path/filepath"
"strings"
)
func configFile() (string, error) {
@ -40,18 +38,15 @@ func homeDir() (string, error) {
return home, nil
}
// If that fails, try the shell
var stdout bytes.Buffer
cmd := exec.Command("sh", "-c", "eval echo ~$USER")
cmd.Stdout = &stdout
if err := cmd.Run(); err != nil {
// If that fails, try build-in module
user, err := user.Current()
if err != nil {
return "", err
}
result := strings.TrimSpace(stdout.String())
if result == "" {
if user.HomeDir == "" {
return "", errors.New("blank output")
}
return result, nil
return user.HomeDir, nil
}