ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

command: Don't treat config warnings as errors 

Meta.backendConfig was incorrectly treating the second return value from
loadBackendConfig as if it were go "error" rather than
tfdiags.Diagnostics, which in turn meant that it would treat warnings like
errors.

This had confusing results because it still returned that
tfdiags.Diagnostics value in its own diagnostics return value, causing the
caller to see warnings even though the backendConfig function had taken
the error codepath.
This commit is contained in:
Martin Atkins 2019-11-14 14:33:43 -08:00
parent beded11422
commit d0f50ff83f
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
command/meta_backend.go
View File

@ -346,9 +346,10 @@ func (m *Meta) backendConfig(opts *BackendOpts) (*configs.Backend, int, tfdiags.
if opts.Config == nil { if opts.Config == nil {
// check if the config was missing, or just not required // check if the config was missing, or just not required
conf, err := m.loadBackendConfig(".") conf, moreDiags := m.loadBackendConfig(".")
if err != nil { diags = diags.Append(moreDiags)
return nil, 0, err if moreDiags.HasErrors() {
return nil, 0, diags
} }
if conf == nil { if conf == nil {