if update func called, there's something to update

This commit is contained in:
Jon Perritt 2015-01-18 20:11:20 -07:00
parent f4a22ae47f
commit cc1445d760
1 changed files with 4 additions and 7 deletions

View File

@ -261,15 +261,12 @@ func resourceComputeInstanceUpdate(d *schema.ResourceData, meta interface{}) err
updateOpts.AccessIPv4 = d.Get("access_ip_v6").(string) updateOpts.AccessIPv4 = d.Get("access_ip_v6").(string)
} }
// If there's nothing to update, don't waste an HTTP call.
if updateOpts != (servers.UpdateOpts{}) {
log.Printf("[DEBUG] Updating Server %s with options: %+v", d.Id(), updateOpts) log.Printf("[DEBUG] Updating Server %s with options: %+v", d.Id(), updateOpts)
_, err := servers.Update(osClient, d.Id(), updateOpts).Extract() _, err := servers.Update(osClient, d.Id(), updateOpts).Extract()
if err != nil { if err != nil {
return fmt.Errorf("Error updating OpenStack server: %s", err) return fmt.Errorf("Error updating OpenStack server: %s", err)
} }
}
if d.HasChange("metadata") { if d.HasChange("metadata") {
var metadataOpts servers.MetadataOpts var metadataOpts servers.MetadataOpts