ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

provider/aws: fix CheckDestroy for group_membership test

This commit is contained in:
Paul Hinze 2015-12-22 08:00:31 -06:00
parent 843a09f664
commit c8e88ed1b4
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
builtin/providers/aws/resource_aws_iam_group_membership_test.go
View File

@ -5,6 +5,7 @@ import (
"testing" "testing"
"github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/awserr"
"github.com/aws/aws-sdk-go/service/iam" "github.com/aws/aws-sdk-go/service/iam"
"github.com/hashicorp/terraform/helper/resource" "github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform" "github.com/hashicorp/terraform/terraform"
@ -55,23 +56,18 @@ func testAccCheckAWSGroupMembershipDestroy(s *terraform.State) error {
group := rs.Primary.Attributes["group"] group := rs.Primary.Attributes["group"]
resp, err := conn.GetGroup(&iam.GetGroupInput{ _, err := conn.GetGroup(&iam.GetGroupInput{
GroupName: aws.String(group), GroupName: aws.String(group),
}) })
if err != nil { if err != nil {
// might error here // Verify the error is what we want
if ae, ok := err.(awserr.Error); ok && ae.Code() == "NoSuchEntity" {
continue
}
return err return err
} }
users := []string{"test-user", "test-user-two", "test-user-three"} return fmt.Errorf("still exists")
for _, u := range resp.Users {
for _, i := range users {
if i == *u.UserName {
return fmt.Errorf("Error: User (%s) still a member of Group (%s)", i, *resp.Group.GroupName)
}
}
}
} }
return nil return nil