internal/initwd: Test that version is rejected for local modules

This was already working, but since that codepath is separate from the
go-getter install codepath it's helpful to have a separate test for it,
in addition to the existing one for go-getter modules.

internal/initwd/module_install_test.go

@@ -129,6 +129,42 @@ func TestModuleInstaller_invalid_version_constraint_error(t *testing.T) {
 	}
 }
 
+func TestModuleInstaller_invalidVersionConstraintGetter(t *testing.T) {
+	fixtureDir := filepath.Clean("test-fixtures/invalid-version-constraint")
+	dir, done := tempChdir(t, fixtureDir)
+	defer done()
+
+	hooks := &testInstallHooks{}
+
+	modulesDir := filepath.Join(dir, ".terraform/modules")
+	inst := NewModuleInstaller(modulesDir, nil)
+	_, diags := inst.InstallModules(".", false, hooks)
+
+	if !diags.HasErrors() {
+		t.Fatal("expected error")
+	} else {
+		assertDiagnosticSummary(t, diags, "Invalid version constraint")
+	}
+}
+
+func TestModuleInstaller_invalidVersionConstraintLocal(t *testing.T) {
+	fixtureDir := filepath.Clean("test-fixtures/invalid-version-constraint-local")
+	dir, done := tempChdir(t, fixtureDir)
+	defer done()
+
+	hooks := &testInstallHooks{}
+
+	modulesDir := filepath.Join(dir, ".terraform/modules")
+	inst := NewModuleInstaller(modulesDir, nil)
+	_, diags := inst.InstallModules(".", false, hooks)
+
+	if !diags.HasErrors() {
+		t.Fatal("expected error")
+	} else {
+		assertDiagnosticSummary(t, diags, "Invalid version constraint")
+	}
+}
+
 func TestModuleInstaller_symlink(t *testing.T) {
 	fixtureDir := filepath.Clean("test-fixtures/local-module-symlink")
 	dir, done := tempChdir(t, fixtureDir)

internal/initwd/test-fixtures/invalid-version-constraint-local/.gitignore

@@ -0,0 +1 @@
+.terraform/*

internal/initwd/test-fixtures/invalid-version-constraint-local/root.tf

@@ -0,0 +1,9 @@
+# This fixture references the github repo at:
+#     https://github.com/hashicorp/terraform-aws-module-installer-acctest
+# However, due to the nature of this test (verifying early error), the URL will not be contacted,
+# and the test is safe to execute as part of the normal test suite.
+
+module "acctest_root" {
+  source  = "github.com/hashicorp/terraform-aws-module-installer-acctest"
+  version = "0.0.1"
+}

internal/initwd/test-fixtures/invalid-version-constraint/root.tf

@@ -1,9 +1,4 @@
-# This fixture references the github repo at:
+module "local" {
-#     https://github.com/hashicorp/terraform-aws-module-installer-acctest
+  source  = "./local"
-# However, due to the nature of this test (verifying early error), the URL will not be contacted,
+  version = "0.0.1" # Version constraint not allowed for a local module
-# and the test is safe to execute as part of the normal test suite.
+}
-
-module "acctest_root" {
-  source  = "github.com/hashicorp/terraform-aws-module-installer-acctest"
-  version = "0.0.1"
-}