Remove 'go get ... vet' from updatedeps target
This package attempts to install itself to GOROOT which will fail for non-root users. Most users will have already installed the vet tool via a system package, so it shouldn't be necessary to 'go get' here. Moreover, the 'vet' make target already checks that it is installed before running it, running 'go get' if necessary. This is the output when running 'make updatedeps' as a regular user without this change: ``` $ make updatedeps go get -u github.com/mitchellh/gox go get -u golang.org/x/tools/cmd/stringer go get -u golang.org/x/tools/cmd/vet go install golang.org/x/tools/cmd/vet: open /usr/local/go/pkg/tool/linux_amd64/vet: permission denied make: *** [updatedeps] Error 1 ```
This commit is contained in:
parent
c18b01fa2a
commit
bcc85be991
1
Makefile
1
Makefile
|
@ -34,7 +34,6 @@ testrace: generate
|
||||||
updatedeps:
|
updatedeps:
|
||||||
go get -u github.com/mitchellh/gox
|
go get -u github.com/mitchellh/gox
|
||||||
go get -u golang.org/x/tools/cmd/stringer
|
go get -u golang.org/x/tools/cmd/stringer
|
||||||
go get -u golang.org/x/tools/cmd/vet
|
|
||||||
go list ./... \
|
go list ./... \
|
||||||
| xargs go list -f '{{join .Deps "\n"}}' \
|
| xargs go list -f '{{join .Deps "\n"}}' \
|
||||||
| grep -v github.com/hashicorp/terraform \
|
| grep -v github.com/hashicorp/terraform \
|
||||||
|
|
Loading…
Reference in New Issue