ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #16172 from roidelapluie/patch-2 

mons-months: fix typo in maintainer-etiquette
This commit is contained in:
Radek Simko 2017-09-25 18:06:04 +01:00 committed by GitHub
parent f846beecbc a4f4c70c60
commit b86967099f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/maintainer-etiquette.md
View File

@ -26,7 +26,7 @@ These apply to all contributors, but maintainers should lead by examples! :wink:
- if the PR submitter has push privileges (recognizable via `Collaborator`, `Member` or `Owner` badge) - we expect **the submitter** to merge their own PR after receiving a positive review from either HC employee or another maintainer. _Exceptions apply - see below._ - if the PR submitter has push privileges (recognizable via `Collaborator`, `Member` or `Owner` badge) - we expect **the submitter** to merge their own PR after receiving a positive review from either HC employee or another maintainer. _Exceptions apply - see below._
- we prefer to use the Github's interface or API to do this, just click the green button - we prefer to use the Github's interface or API to do this, just click the green button
- squash? - squash?
- squash when you think the commit history is irrelevant (will not be helpful for any readers in T+6mons) - squash when you think the commit history is irrelevant (will not be helpful for any readers in T+6months)
- Add the new PR to the **Changelog** if it may affect the user (almost any PR except test changes and docs updates) - Add the new PR to the **Changelog** if it may affect the user (almost any PR except test changes and docs updates)
- we prefer to use the Github's web interface to modify the Changelog and use `[GH-12345]` to format the PR number. These will be turned into links as part of the release process. Breaking changes should be always documented separately. - we prefer to use the Github's web interface to modify the Changelog and use `[GH-12345]` to format the PR number. These will be turned into links as part of the release process. Breaking changes should be always documented separately.