command/jsonconfig: add missing fields from configuration output (#20387)
Display depends_on for resources and outputs, and description for outputs.
This commit is contained in:
parent
1bef862e3a
commit
b14472f22c
|
@ -32,7 +32,7 @@ type providerConfig struct {
|
|||
}
|
||||
|
||||
type module struct {
|
||||
Outputs map[string]configOutput `json:"outputs,omitempty"`
|
||||
Outputs map[string]output `json:"outputs,omitempty"`
|
||||
// Resources are sorted in a user-friendly order that is undefined at this
|
||||
// time, but consistent.
|
||||
Resources []resource `json:"resources,omitempty"`
|
||||
|
@ -90,11 +90,15 @@ type resource struct {
|
|||
// These are omitted if the corresponding argument isn't set.
|
||||
CountExpression *expression `json:"count_expression,omitempty"`
|
||||
ForEachExpression *expression `json:"for_each_expression,omitempty"`
|
||||
|
||||
DependsOn []string `json:"depends_on,omitempty"`
|
||||
}
|
||||
|
||||
type configOutput struct {
|
||||
type output struct {
|
||||
Sensitive bool `json:"sensitive,omitempty"`
|
||||
Expression expression `json:"expression,omitempty"`
|
||||
DependsOn []string `json:"depends_on,omitempty"`
|
||||
Description string `json:"description,omitempty"`
|
||||
}
|
||||
|
||||
type provisioner struct {
|
||||
|
@ -161,12 +165,30 @@ func marshalModule(c *configs.Config, schemas *terraform.Schemas) (module, error
|
|||
rs = append(managedResources, dataResources...)
|
||||
module.Resources = rs
|
||||
|
||||
outputs := make(map[string]configOutput)
|
||||
outputs := make(map[string]output)
|
||||
for _, v := range c.Module.Outputs {
|
||||
outputs[v.Name] = configOutput{
|
||||
o := output{
|
||||
Sensitive: v.Sensitive,
|
||||
Expression: marshalExpression(v.Expr),
|
||||
}
|
||||
if v.Description != "" {
|
||||
o.Description = v.Description
|
||||
}
|
||||
if len(v.DependsOn) > 0 {
|
||||
dependencies := make([]string, len(v.DependsOn))
|
||||
for i, d := range v.DependsOn {
|
||||
ref, diags := addrs.ParseRef(d)
|
||||
// we should not get an error here, because `terraform validate`
|
||||
// would have complained well before this point, but if we do we'll
|
||||
// silenty skip it.
|
||||
if !diags.HasErrors() {
|
||||
dependencies[i] = ref.Subject.String()
|
||||
}
|
||||
}
|
||||
o.DependsOn = dependencies
|
||||
}
|
||||
|
||||
outputs[v.Name] = o
|
||||
}
|
||||
module.Outputs = outputs
|
||||
module.ModuleCalls = marshalModuleCalls(c, schemas)
|
||||
|
@ -289,6 +311,20 @@ func marshalResources(resources map[string]*configs.Resource, schemas *terraform
|
|||
r.Provisioners = provisioners
|
||||
}
|
||||
|
||||
if len(v.DependsOn) > 0 {
|
||||
dependencies := make([]string, len(v.DependsOn))
|
||||
for i, d := range v.DependsOn {
|
||||
ref, diags := addrs.ParseRef(d)
|
||||
// we should not get an error here, because `terraform validate`
|
||||
// would have complained well before this point, but if we do we'll
|
||||
// silenty skip it.
|
||||
if !diags.HasErrors() {
|
||||
dependencies[i] = ref.Subject.String()
|
||||
}
|
||||
}
|
||||
r.DependsOn = dependencies
|
||||
}
|
||||
|
||||
rs = append(rs, r)
|
||||
}
|
||||
sort.Slice(rs, func(i, j int) bool {
|
||||
|
|
|
@ -5,4 +5,5 @@ module "test" {
|
|||
|
||||
output "test" {
|
||||
value = module.test.test
|
||||
depends_on = [module.test]
|
||||
}
|
||||
|
|
|
@ -61,7 +61,6 @@
|
|||
"type": "test_instance",
|
||||
"name": "test",
|
||||
"index": 0,
|
||||
"deposed": true,
|
||||
"change": {
|
||||
"actions": [
|
||||
"create"
|
||||
|
@ -83,7 +82,6 @@
|
|||
"type": "test_instance",
|
||||
"name": "test",
|
||||
"index": 1,
|
||||
"deposed": true,
|
||||
"change": {
|
||||
"actions": [
|
||||
"create"
|
||||
|
@ -105,7 +103,6 @@
|
|||
"type": "test_instance",
|
||||
"name": "test",
|
||||
"index": 2,
|
||||
"deposed": true,
|
||||
"change": {
|
||||
"actions": [
|
||||
"create"
|
||||
|
@ -139,7 +136,10 @@
|
|||
"references": [
|
||||
"module.test.test"
|
||||
]
|
||||
}
|
||||
},
|
||||
"depends_on": [
|
||||
"module.test"
|
||||
]
|
||||
}
|
||||
},
|
||||
"module_calls": {
|
||||
|
|
Loading…
Reference in New Issue