Merge pull request #30095 from hashicorp/jbardin/invalid-provider-name

skip provider resolution when there are errors

internal/configs/config_build.go

@@ -23,9 +23,13 @@ func BuildConfig(root *Module, walker ModuleWalker) (*Config, hcl.Diagnostics) {
 	cfg.Root = cfg // Root module is self-referential.
 	cfg.Children, diags = buildChildModules(cfg, walker)
 
-	// Now that the config is built, we can connect the provider names to all
+	// Skip provider resolution if there are any errors, since the provider
-	// the known types for validation.
+	// configurations themselves may not be valid.
-	cfg.resolveProviderTypes()
+	if !diags.HasErrors() {
+		// Now that the config is built, we can connect the provider names to all
+		// the known types for validation.
+		cfg.resolveProviderTypes()
+	}
 
 	diags = append(diags, validateProviderConfigs(nil, cfg, false)...)
 

internal/configs/testdata/config-diagnostics/invalid-provider/errors

@@ -0,0 +1 @@
+main.tf:1,1-20: Invalid provider local name; crash_es is an invalid provider local name

internal/configs/testdata/config-diagnostics/invalid-provider/main.tf

@@ -0,0 +1,3 @@
+module "mod" {
+  source = "./mod"
+}

internal/configs/testdata/config-diagnostics/invalid-provider/mod/main.tf

@@ -0,0 +1,2 @@
+provider "crash_es" {
+}

internal/configs/testdata/config-diagnostics/invalid-provider/warnings

@@ -0,0 +1 @@
+Empty provider configuration blocks are not required