terraform: planning and applying multi-count resources tests

This commit is contained in:
Mitchell Hashimoto 2014-07-03 21:24:17 -07:00
parent ba144ef933
commit a616218d13
5 changed files with 146 additions and 1 deletions

View File

@ -3,6 +3,7 @@ package terraform
import (
"fmt"
"log"
"strings"
"sync"
"sync/atomic"
@ -509,6 +510,9 @@ func (c *Context) genericWalkFn(
vars[fmt.Sprintf("var.%s", k)] = v
}
// This will keep track of the counts of multi-count resources
counts := make(map[string]int)
// This will keep track of whether we're stopped or not
var stop uint32 = 0
@ -523,8 +527,20 @@ func (c *Context) genericWalkFn(
return nil
}
// Calculate any aggregate interpolated variables if we have to.
// Aggregate variables (such as "test_instance.foo.*.id") are not
// pre-computed since the fanout would be expensive. We calculate
// them on-demand here.
computeAggregateVars(&l, n, counts, vars)
switch m := n.Meta.(type) {
case *GraphNodeResource:
case *GraphNodeResourceMeta:
// Record the count and then just ignore
l.Lock()
counts[m.ID] = m.Count
l.Unlock()
return nil
case *GraphNodeResourceProvider:
var rc *ResourceConfig
if m.Config != nil {
@ -543,6 +559,8 @@ func (c *Context) genericWalkFn(
}
return nil
default:
panic(fmt.Sprintf("unknown graph node: %#v", n.Meta))
}
rn := n.Meta.(*GraphNodeResource)
@ -603,3 +621,66 @@ func (c *Context) genericWalkFn(
return nil
}
}
func computeAggregateVars(
l *sync.RWMutex,
n *depgraph.Noun,
cs map[string]int,
vs map[string]string) {
var ivars map[string]config.InterpolatedVariable
switch m := n.Meta.(type) {
case *GraphNodeResource:
ivars = m.Config.RawConfig.Variables
case *GraphNodeResourceProvider:
if m.Config != nil {
ivars = m.Config.RawConfig.Variables
}
}
if len(ivars) == 0 {
return
}
for _, v := range ivars {
rv, ok := v.(*config.ResourceVariable)
if !ok {
continue
}
idx := strings.Index(rv.Field, ".")
if idx == -1 {
// It isn't an aggregated var
continue
}
if rv.Field[:idx] != "*" {
// It isn't an aggregated var
continue
}
field := rv.Field[idx+1:]
// Get the meta node so that we can determine the count
key := fmt.Sprintf("%s.%s", rv.Type, rv.Name)
l.RLock()
count, ok := cs[key]
l.RUnlock()
if !ok {
// This should never happen due to semantic checks
panic(fmt.Sprintf(
"non-existent resource variable access: %s\n\n%#v", key, rv))
}
var values []string
for i := 0; i < count; i++ {
key := fmt.Sprintf(
"%s.%s.%d.%s",
rv.Type,
rv.Name,
i,
field)
if v, ok := vs[key]; ok {
values = append(values, v)
}
}
vs[rv.FullKey()] = strings.Join(values, ",")
}
}

View File

@ -641,6 +641,33 @@ func TestContextPlan_computed(t *testing.T) {
}
}
func TestContextPlan_count(t *testing.T) {
c := testConfig(t, "plan-count")
p := testProvider("aws")
p.DiffFn = testDiffFn
ctx := testContext(t, &ContextOpts{
Config: c,
Providers: map[string]ResourceProviderFactory{
"aws": testProviderFuncFixed(p),
},
})
plan, err := ctx.Plan(nil)
if err != nil {
t.Fatalf("err: %s", err)
}
if len(plan.Diff.Resources) < 6 {
t.Fatalf("bad: %#v", plan.Diff.Resources)
}
actual := strings.TrimSpace(plan.String())
expected := strings.TrimSpace(testTerraformPlanCountStr)
if actual != expected {
t.Fatalf("bad:\n%s", actual)
}
}
func TestContextPlan_destroy(t *testing.T) {
c := testConfig(t, "plan-destroy")
p := testProvider("aws")

View File

@ -62,6 +62,7 @@ type GraphNodeResource struct {
// metadata for a resource. There will be one meta node for every resource
// in the configuration.
type GraphNodeResourceMeta struct {
ID string
Name string
Type string
Count int
@ -197,7 +198,8 @@ func graphAddConfigResources(
metaNoun := &depgraph.Noun{
Name: r.Id(),
Meta: &GraphNodeResourceMeta{
Name: r.Id(),
ID: r.Id(),
Name: r.Name,
Type: r.Type,
Count: r.Count,
},

View File

@ -155,6 +155,33 @@ STATE:
<no state>
`
const testTerraformPlanCountStr = `
DIFF:
UPDATE: aws_instance.bar
foo: "" => "foo,foo,foo,foo,foo"
type: "" => "aws_instance"
UPDATE: aws_instance.foo.0
foo: "" => "foo"
type: "" => "aws_instance"
UPDATE: aws_instance.foo.1
foo: "" => "foo"
type: "" => "aws_instance"
UPDATE: aws_instance.foo.2
foo: "" => "foo"
type: "" => "aws_instance"
UPDATE: aws_instance.foo.3
foo: "" => "foo"
type: "" => "aws_instance"
UPDATE: aws_instance.foo.4
foo: "" => "foo"
type: "" => "aws_instance"
STATE:
<no state>
`
const testTerraformPlanDestroyStr = `
DIFF:

View File

@ -0,0 +1,8 @@
resource "aws_instance" "foo" {
count = 5
foo = "foo"
}
resource "aws_instance" "bar" {
foo = "${aws_instance.foo.*.foo}"
}