From 896d1d30fb95e2fcca7813ac02f106625cabfaae Mon Sep 17 00:00:00 2001
From: clint shryock <clint@ctshryock.com>
Date: Thu, 16 Feb 2017 16:18:39 -0600
Subject: [PATCH] provider/fastly: Make Fastly Service Backends optional

Backends must be defined in the config, but may optionally be declared
inside custom VCL. Here we mark Backends optional to enable that.
---
 .../fastly/resource_fastly_service_v1.go      |  2 +-
 .../resource_fastly_service_v1_vcl_test.go    | 25 +++++++++++--------
 .../fastly/r/service_v1.html.markdown         |  5 ++--
 3 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/builtin/providers/fastly/resource_fastly_service_v1.go b/builtin/providers/fastly/resource_fastly_service_v1.go
index 565839b6a..e36fc946f 100644
--- a/builtin/providers/fastly/resource_fastly_service_v1.go
+++ b/builtin/providers/fastly/resource_fastly_service_v1.go
@@ -109,7 +109,7 @@ func resourceServiceV1() *schema.Resource {
 
 			"backend": {
 				Type:     schema.TypeSet,
-				Required: true,
+				Optional: true,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						// required fields
diff --git a/builtin/providers/fastly/resource_fastly_service_v1_vcl_test.go b/builtin/providers/fastly/resource_fastly_service_v1_vcl_test.go
index 0d0c47543..c95a0f2d0 100644
--- a/builtin/providers/fastly/resource_fastly_service_v1_vcl_test.go
+++ b/builtin/providers/fastly/resource_fastly_service_v1_vcl_test.go
@@ -82,11 +82,6 @@ resource "fastly_service_v1" "foo" {
     comment = "tf-testing-domain"
   }
 
-  backend {
-    address = "aws.amazon.com"
-    name    = "amazon docs"
-  }
-
   vcl {
     name    = "my_custom_main_vcl"
     content = <<EOF
@@ -99,6 +94,11 @@ sub vcl_recv {
 
     return(lookup);
 }
+
+backend amazondocs {
+  .host = "127.0.0.1";
+  .port = "80";
+}
 EOF
     main    = true
   }
@@ -117,11 +117,6 @@ resource "fastly_service_v1" "foo" {
     comment = "tf-testing-domain"
   }
 
-  backend {
-    address = "aws.amazon.com"
-    name    = "amazon docs"
-  }
-
   vcl {
     name    = "my_custom_main_vcl"
     content = <<EOF
@@ -134,6 +129,11 @@ sub vcl_recv {
 
     return(lookup);
 }
+
+backend amazondocs {
+  .host = "127.0.0.1";
+  .port = "80";
+}
 EOF
     main    = true
   }
@@ -144,6 +144,11 @@ EOF
 sub vcl_error {
 #FASTLY error
 }
+
+backend amazondocs {
+  .host = "127.0.0.1";
+  .port = "80";
+}
 EOF
         }
 
diff --git a/website/source/docs/providers/fastly/r/service_v1.html.markdown b/website/source/docs/providers/fastly/r/service_v1.html.markdown
index 1fabbe26f..82713a66d 100644
--- a/website/source/docs/providers/fastly/r/service_v1.html.markdown
+++ b/website/source/docs/providers/fastly/r/service_v1.html.markdown
@@ -132,8 +132,9 @@ The following arguments are supported:
 * `name` - (Required) The unique name for the Service to create.
 * `domain` - (Required) A set of Domain names to serve as entry points for your
 Service. Defined below.
-* `backend` - (Required) A set of Backends to service requests from your Domains.
-Defined below.
+* `backend` - (Optional) A set of Backends to service requests from your Domains.
+Defined below. Backends must be defined in this argument, or defined in the
+`vcl` argument below
 * `condition` - (Optional) A set of conditions to add logic to any basic
 configuration object in this service. Defined below.
 * `cache_setting` - (Optional) A set of Cache Settings, allowing you to override