ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #10656 from hashicorp/b-muti-lifecycle 

config: error when loading multiple lifecycle blocks
This commit is contained in:
Mitchell Hashimoto 2016-12-12 09:23:02 -08:00 committed by GitHub
parent 3ecdc057b5 5d684b399c
commit 882a5c49d7
3 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
config/loader_hcl.go
View File

@ -781,6 +781,12 @@ func loadManagedResourcesHcl(list *ast.ObjectList) ([]*Resource, error) {
// destroying the existing instance // destroying the existing instance
var lifecycle ResourceLifecycle var lifecycle ResourceLifecycle
if o := listVal.Filter("lifecycle"); len(o.Items) > 0 { if o := listVal.Filter("lifecycle"); len(o.Items) > 0 {
if len(o.Items) > 1 {
return nil, fmt.Errorf(
"%s[%s]: Multiple lifecycle blocks found, expected one",
t, k)
}
// Check for invalid keys // Check for invalid keys
valid := []string{"create_before_destroy", "ignore_changes", "prevent_destroy"} valid := []string{"create_before_destroy", "ignore_changes", "prevent_destroy"}
if err := checkHCLKeys(o.Items[0].Val, valid); err != nil { if err := checkHCLKeys(o.Items[0].Val, valid); err != nil {

7
config/loader_test.go
View File

@ -78,6 +78,13 @@ func TestLoadFile_resourceArityMistake(t *testing.T) {
} }
} }
func TestLoadFile_resourceMultiLifecycle(t *testing.T) {
_, err := LoadFile(filepath.Join(fixtureDir, "resource-multi-lifecycle.tf"))
if err == nil {
t.Fatal("should have error")
}
}
func TestLoadFile_dataSourceArityMistake(t *testing.T) { func TestLoadFile_dataSourceArityMistake(t *testing.T) {
_, err := LoadFile(filepath.Join(fixtureDir, "data-source-arity-mistake.tf")) _, err := LoadFile(filepath.Join(fixtureDir, "data-source-arity-mistake.tf"))
if err == nil { if err == nil {

4
config/test-fixtures/resource-multi-lifecycle.tf Normal file
View File

@ -0,0 +1,4 @@
resource "aws_instance" "foo" {
lifecycle {}
lifecycle {}
}