ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #5263 from uber/b-element-negative 

Error out on negative indices in element()
This commit is contained in:
James Nugent 2016-03-16 09:39:35 +00:00
parent e56d0f708c c0034e672b
commit 87550b2b72
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/interpolate_funcs.go
View File

@ -477,7 +477,7 @@ func interpolationFuncElement() ast.Function {
list := StringList(args[0].(string)) list := StringList(args[0].(string))
index, err := strconv.Atoi(args[1].(string)) index, err := strconv.Atoi(args[1].(string))
if err != nil { if err != nil || index < 0 {
return "", fmt.Errorf( return "", fmt.Errorf(
"invalid number for index, got %s", args[1]) "invalid number for index, got %s", args[1])
} }

8
config/interpolate_funcs_test.go
View File

@ -778,6 +778,14 @@ func TestInterpolateFuncElement(t *testing.T) {
false, false,
}, },
// Negative number should fail
{
fmt.Sprintf(`${element("%s", "-1")}`,
NewStringList([]string{"foo"}).String()),
nil,
true,
},
// Too many args // Too many args
{ {
fmt.Sprintf(`${element("%s", "0", "2")}`, fmt.Sprintf(`${element("%s", "0", "2")}`,