provider/google: Collision fixes in compute backend service tests

This commit is contained in:
Paul Hinze 2016-01-05 12:39:30 -06:00
parent c4aff4a585
commit 8677f8eea7
1 changed files with 63 additions and 46 deletions

View File

@ -4,12 +4,16 @@ import (
"fmt" "fmt"
"testing" "testing"
"github.com/hashicorp/terraform/helper/acctest"
"github.com/hashicorp/terraform/helper/resource" "github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform" "github.com/hashicorp/terraform/terraform"
"google.golang.org/api/compute/v1" "google.golang.org/api/compute/v1"
) )
func TestAccComputeBackendService_basic(t *testing.T) { func TestAccComputeBackendService_basic(t *testing.T) {
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
checkName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
extraCheckName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
var svc compute.BackendService var svc compute.BackendService
resource.Test(t, resource.TestCase{ resource.Test(t, resource.TestCase{
@ -18,14 +22,15 @@ func TestAccComputeBackendService_basic(t *testing.T) {
CheckDestroy: testAccCheckComputeBackendServiceDestroy, CheckDestroy: testAccCheckComputeBackendServiceDestroy,
Steps: []resource.TestStep{ Steps: []resource.TestStep{
resource.TestStep{ resource.TestStep{
Config: testAccComputeBackendService_basic, Config: testAccComputeBackendService_basic(serviceName, checkName),
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckComputeBackendServiceExists( testAccCheckComputeBackendServiceExists(
"google_compute_backend_service.foobar", &svc), "google_compute_backend_service.foobar", &svc),
), ),
}, },
resource.TestStep{ resource.TestStep{
Config: testAccComputeBackendService_basicModified, Config: testAccComputeBackendService_basicModified(
serviceName, checkName, extraCheckName),
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckComputeBackendServiceExists( testAccCheckComputeBackendServiceExists(
"google_compute_backend_service.foobar", &svc), "google_compute_backend_service.foobar", &svc),
@ -36,6 +41,10 @@ func TestAccComputeBackendService_basic(t *testing.T) {
} }
func TestAccComputeBackendService_withBackend(t *testing.T) { func TestAccComputeBackendService_withBackend(t *testing.T) {
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
igName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
itName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
checkName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
var svc compute.BackendService var svc compute.BackendService
resource.Test(t, resource.TestCase{ resource.Test(t, resource.TestCase{
@ -44,7 +53,8 @@ func TestAccComputeBackendService_withBackend(t *testing.T) {
CheckDestroy: testAccCheckComputeBackendServiceDestroy, CheckDestroy: testAccCheckComputeBackendServiceDestroy,
Steps: []resource.TestStep{ Steps: []resource.TestStep{
resource.TestStep{ resource.TestStep{
Config: testAccComputeBackendService_withBackend, Config: testAccComputeBackendService_withBackend(
serviceName, igName, itName, checkName),
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckComputeBackendServiceExists( testAccCheckComputeBackendServiceExists(
"google_compute_backend_service.lipsum", &svc), "google_compute_backend_service.lipsum", &svc),
@ -111,44 +121,50 @@ func testAccCheckComputeBackendServiceExists(n string, svc *compute.BackendServi
} }
} }
const testAccComputeBackendService_basic = ` func testAccComputeBackendService_basic(serviceName, checkName string) string {
return fmt.Sprintf(`
resource "google_compute_backend_service" "foobar" { resource "google_compute_backend_service" "foobar" {
name = "blablah" name = "%s"
health_checks = ["${google_compute_http_health_check.zero.self_link}"] health_checks = ["${google_compute_http_health_check.zero.self_link}"]
} }
resource "google_compute_http_health_check" "zero" { resource "google_compute_http_health_check" "zero" {
name = "tf-test-zero" name = "%s"
request_path = "/" request_path = "/"
check_interval_sec = 1 check_interval_sec = 1
timeout_sec = 1 timeout_sec = 1
} }
` `, serviceName, checkName)
}
const testAccComputeBackendService_basicModified = ` func testAccComputeBackendService_basicModified(serviceName, checkOne, checkTwo string) string {
return fmt.Sprintf(`
resource "google_compute_backend_service" "foobar" { resource "google_compute_backend_service" "foobar" {
name = "blablah" name = "%s"
health_checks = ["${google_compute_http_health_check.one.self_link}"] health_checks = ["${google_compute_http_health_check.one.self_link}"]
} }
resource "google_compute_http_health_check" "zero" { resource "google_compute_http_health_check" "zero" {
name = "tf-test-zero" name = "%s"
request_path = "/" request_path = "/"
check_interval_sec = 1 check_interval_sec = 1
timeout_sec = 1 timeout_sec = 1
} }
resource "google_compute_http_health_check" "one" { resource "google_compute_http_health_check" "one" {
name = "tf-test-one" name = "%s"
request_path = "/one" request_path = "/one"
check_interval_sec = 30 check_interval_sec = 30
timeout_sec = 30 timeout_sec = 30
} }
` `, serviceName, checkOne, checkTwo)
}
const testAccComputeBackendService_withBackend = ` func testAccComputeBackendService_withBackend(
serviceName, igName, itName, checkName string) string {
return fmt.Sprintf(`
resource "google_compute_backend_service" "lipsum" { resource "google_compute_backend_service" "lipsum" {
name = "hello-world-bs" name = "%s"
description = "Hello World 1234" description = "Hello World 1234"
port_name = "http" port_name = "http"
protocol = "HTTP" protocol = "HTTP"
@ -162,7 +178,7 @@ resource "google_compute_backend_service" "lipsum" {
} }
resource "google_compute_instance_group_manager" "foobar" { resource "google_compute_instance_group_manager" "foobar" {
name = "terraform-test" name = "%s"
instance_template = "${google_compute_instance_template.foobar.self_link}" instance_template = "${google_compute_instance_template.foobar.self_link}"
base_instance_name = "foobar" base_instance_name = "foobar"
zone = "us-central1-f" zone = "us-central1-f"
@ -170,7 +186,7 @@ resource "google_compute_instance_group_manager" "foobar" {
} }
resource "google_compute_instance_template" "foobar" { resource "google_compute_instance_template" "foobar" {
name = "terraform-test" name = "%s"
machine_type = "n1-standard-1" machine_type = "n1-standard-1"
network_interface { network_interface {
@ -185,9 +201,10 @@ resource "google_compute_instance_template" "foobar" {
} }
resource "google_compute_http_health_check" "default" { resource "google_compute_http_health_check" "default" {
name = "test2" name = "%s"
request_path = "/" request_path = "/"
check_interval_sec = 1 check_interval_sec = 1
timeout_sec = 1 timeout_sec = 1
} }
` `, serviceName, igName, itName, checkName)
}