terraform: test that depends_on is used for destroy ordering
This commit is contained in:
parent
5e037421b5
commit
791a02e6e4
|
@ -508,6 +508,156 @@ func TestContext2Apply_destroyComputed(t *testing.T) {
|
|||
}
|
||||
}
|
||||
|
||||
// Test that the destroy operation uses depends_on as a source of ordering.
|
||||
func TestContext2Apply_destroyDependsOn(t *testing.T) {
|
||||
// It is possible for this to be racy, so we loop a number of times
|
||||
// just to check.
|
||||
for i := 0; i < 10; i++ {
|
||||
testContext2Apply_destroyDependsOn(t)
|
||||
}
|
||||
}
|
||||
|
||||
func testContext2Apply_destroyDependsOn(t *testing.T) {
|
||||
m := testModule(t, "apply-destroy-depends-on")
|
||||
p := testProvider("aws")
|
||||
p.ApplyFn = testApplyFn
|
||||
p.DiffFn = testDiffFn
|
||||
state := &State{
|
||||
Modules: []*ModuleState{
|
||||
&ModuleState{
|
||||
Path: rootModulePath,
|
||||
Resources: map[string]*ResourceState{
|
||||
"aws_instance.foo": &ResourceState{
|
||||
Type: "aws_instance",
|
||||
Primary: &InstanceState{
|
||||
ID: "foo",
|
||||
Attributes: map[string]string{},
|
||||
},
|
||||
},
|
||||
|
||||
"aws_instance.bar": &ResourceState{
|
||||
Type: "aws_instance",
|
||||
Primary: &InstanceState{
|
||||
ID: "bar",
|
||||
Attributes: map[string]string{},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
// Record the order we see Apply
|
||||
var actual []string
|
||||
var actualLock sync.Mutex
|
||||
p.ApplyFn = func(
|
||||
info *InstanceInfo, _ *InstanceState, _ *InstanceDiff) (*InstanceState, error) {
|
||||
actualLock.Lock()
|
||||
defer actualLock.Unlock()
|
||||
actual = append(actual, info.Id)
|
||||
return nil, nil
|
||||
}
|
||||
|
||||
ctx := testContext2(t, &ContextOpts{
|
||||
Module: m,
|
||||
Providers: map[string]ResourceProviderFactory{
|
||||
"aws": testProviderFuncFixed(p),
|
||||
},
|
||||
State: state,
|
||||
Destroy: true,
|
||||
Parallelism: 1, // To check ordering
|
||||
})
|
||||
|
||||
if _, err := ctx.Plan(); err != nil {
|
||||
t.Fatalf("err: %s", err)
|
||||
}
|
||||
|
||||
if _, err := ctx.Apply(); err != nil {
|
||||
t.Fatalf("err: %s", err)
|
||||
}
|
||||
|
||||
expected := []string{"aws_instance.foo", "aws_instance.bar"}
|
||||
if !reflect.DeepEqual(actual, expected) {
|
||||
t.Fatalf("bad: %#v", actual)
|
||||
}
|
||||
}
|
||||
|
||||
// Test that destroy ordering is correct with dependencies only
|
||||
// in the state.
|
||||
func TestContext2Apply_destroyDependsOnStateOnly(t *testing.T) {
|
||||
// It is possible for this to be racy, so we loop a number of times
|
||||
// just to check.
|
||||
for i := 0; i < 10; i++ {
|
||||
testContext2Apply_destroyDependsOnStateOnly(t)
|
||||
}
|
||||
}
|
||||
|
||||
func testContext2Apply_destroyDependsOnStateOnly(t *testing.T) {
|
||||
m := testModule(t, "empty")
|
||||
p := testProvider("aws")
|
||||
p.ApplyFn = testApplyFn
|
||||
p.DiffFn = testDiffFn
|
||||
state := &State{
|
||||
Modules: []*ModuleState{
|
||||
&ModuleState{
|
||||
Path: rootModulePath,
|
||||
Resources: map[string]*ResourceState{
|
||||
"aws_instance.foo": &ResourceState{
|
||||
Type: "aws_instance",
|
||||
Primary: &InstanceState{
|
||||
ID: "foo",
|
||||
Attributes: map[string]string{},
|
||||
},
|
||||
},
|
||||
|
||||
"aws_instance.bar": &ResourceState{
|
||||
Type: "aws_instance",
|
||||
Primary: &InstanceState{
|
||||
ID: "bar",
|
||||
Attributes: map[string]string{},
|
||||
},
|
||||
Dependencies: []string{"aws_instance.foo"},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
// Record the order we see Apply
|
||||
var actual []string
|
||||
var actualLock sync.Mutex
|
||||
p.ApplyFn = func(
|
||||
info *InstanceInfo, _ *InstanceState, _ *InstanceDiff) (*InstanceState, error) {
|
||||
actualLock.Lock()
|
||||
defer actualLock.Unlock()
|
||||
actual = append(actual, info.Id)
|
||||
return nil, nil
|
||||
}
|
||||
|
||||
ctx := testContext2(t, &ContextOpts{
|
||||
Module: m,
|
||||
Providers: map[string]ResourceProviderFactory{
|
||||
"aws": testProviderFuncFixed(p),
|
||||
},
|
||||
State: state,
|
||||
Destroy: true,
|
||||
Parallelism: 1, // To check ordering
|
||||
})
|
||||
|
||||
if _, err := ctx.Plan(); err != nil {
|
||||
t.Fatalf("err: %s", err)
|
||||
}
|
||||
|
||||
if _, err := ctx.Apply(); err != nil {
|
||||
t.Fatalf("err: %s", err)
|
||||
}
|
||||
|
||||
expected := []string{"aws_instance.bar", "aws_instance.foo"}
|
||||
if !reflect.DeepEqual(actual, expected) {
|
||||
t.Fatalf("bad: %#v", actual)
|
||||
}
|
||||
}
|
||||
|
||||
func TestContext2Apply_dataBasic(t *testing.T) {
|
||||
m := testModule(t, "apply-data-basic")
|
||||
p := testProvider("null")
|
||||
|
|
|
@ -0,0 +1,5 @@
|
|||
resource "aws_instance" "foo" {
|
||||
depends_on = ["aws_instance.bar"]
|
||||
}
|
||||
|
||||
resource "aws_instance" "bar" {}
|
|
@ -0,0 +1 @@
|
|||
# Empty, use this for any test that requires a module but no config.
|
|
@ -0,0 +1,5 @@
|
|||
resource "aws_instance" "foo" {}
|
||||
|
||||
resource "aws_instance" "bar" {
|
||||
depends_on = ["aws_instance.foo"]
|
||||
}
|
|
@ -30,6 +30,31 @@ func TestDestroyTransformer(t *testing.T) {
|
|||
}
|
||||
}
|
||||
|
||||
func TestDestroyTransformer_dependsOn(t *testing.T) {
|
||||
mod := testModule(t, "transform-destroy-depends-on")
|
||||
|
||||
g := Graph{Path: RootModulePath}
|
||||
{
|
||||
tf := &ConfigTransformer{Module: mod}
|
||||
if err := tf.Transform(&g); err != nil {
|
||||
t.Fatalf("err: %s", err)
|
||||
}
|
||||
}
|
||||
|
||||
{
|
||||
tf := &DestroyTransformer{}
|
||||
if err := tf.Transform(&g); err != nil {
|
||||
t.Fatalf("err: %s", err)
|
||||
}
|
||||
}
|
||||
|
||||
actual := strings.TrimSpace(g.String())
|
||||
expected := strings.TrimSpace(testTransformDestroyBasicStr)
|
||||
if actual != expected {
|
||||
t.Fatalf("bad:\n\n%s", actual)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateBeforeDestroyTransformer(t *testing.T) {
|
||||
mod := testModule(t, "transform-create-before-destroy-basic")
|
||||
|
||||
|
|
Loading…
Reference in New Issue