ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

provider/aws: Make aws_dms_endpoint database_name optional (#11792) 

Not required for MySQL

Fixes: #11791
This commit is contained in:
Paul Stack 2017-02-09 11:43:14 +00:00 committed by GitHub
parent beb00e287d
commit 7310b26896
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin/providers/aws/resource_aws_dms_endpoint.go
View File

@ -32,7 +32,7 @@ func resourceAwsDmsEndpoint() *schema.Resource {
}, },
"database_name": { "database_name": {
Type: schema.TypeString, Type: schema.TypeString,
Required: true, Optional: true,
}, },
"endpoint_arn": { "endpoint_arn": {
Type: schema.TypeString, Type: schema.TypeString,
@ -118,7 +118,6 @@ func resourceAwsDmsEndpointCreate(d *schema.ResourceData, meta interface{}) erro
conn := meta.(*AWSClient).dmsconn conn := meta.(*AWSClient).dmsconn
request := &dms.CreateEndpointInput{ request := &dms.CreateEndpointInput{
DatabaseName: aws.String(d.Get("database_name").(string)),
EndpointIdentifier: aws.String(d.Get("endpoint_id").(string)), EndpointIdentifier: aws.String(d.Get("endpoint_id").(string)),
EndpointType: aws.String(d.Get("endpoint_type").(string)), EndpointType: aws.String(d.Get("endpoint_type").(string)),
EngineName: aws.String(d.Get("engine_name").(string)), EngineName: aws.String(d.Get("engine_name").(string)),
@ -129,6 +128,9 @@ func resourceAwsDmsEndpointCreate(d *schema.ResourceData, meta interface{}) erro
Username: aws.String(d.Get("username").(string)), Username: aws.String(d.Get("username").(string)),
} }
if v, ok := d.GetOk("database_name"); ok {
request.DatabaseName = aws.String(v.(string))
}
if v, ok := d.GetOk("certificate_arn"); ok { if v, ok := d.GetOk("certificate_arn"); ok {
request.CertificateArn = aws.String(v.(string)) request.CertificateArn = aws.String(v.(string))
} }

2
website/source/docs/providers/aws/r/dms_endpoint.html.markdown
View File

@ -38,7 +38,7 @@ resource "aws_dms_endpoint" "test" {
The following arguments are supported: The following arguments are supported:
* `certificate_arn` - (Optional, Default: empty string) The Amazon Resource Name (ARN) for the certificate. * `certificate_arn` - (Optional, Default: empty string) The Amazon Resource Name (ARN) for the certificate.
* `database_name` - (Optional, Default: empty string) The name of the endpoint database. * `database_name` - (Optional) The name of the endpoint database.
* `endpoint_id` - (Required) The database endpoint identifier. * `endpoint_id` - (Required) The database endpoint identifier.
- Must contain from 1 to 255 alphanumeric characters or hyphens. - Must contain from 1 to 255 alphanumeric characters or hyphens.