Merge pull request #25408 from hashicorp/alisdair/fix-panic-provider-alias

configs: Fail early for invalid resource provider

configs/resource.go

@@ -422,6 +422,9 @@ func decodeProviderConfigRef(expr hcl.Expression, argName string) (*ProviderConf
 	name := traversal.RootName()
 	nameDiags := checkProviderNameNormalized(name, traversal[0].SourceRange())
 	diags = append(diags, nameDiags...)
+	if diags.HasErrors() {
+		return nil, diags
+	}
 
 	ret := &ProviderConfigRef{
 		Name:      name,

configs/testdata/invalid-files/data-invalid-provider-reference.tf

@@ -0,0 +1,3 @@
+data "test_resource" "t" {
+  provider = my_test
+}

configs/testdata/invalid-files/resource-invalid-provider-reference.tf

@@ -0,0 +1,3 @@
+resource "test_resource" "t" {
+  provider = my_test
+}