ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Review by @paddyforan: better test possible network error

This commit is contained in:
Thomas Poindessous 2017-03-23 12:05:14 +01:00
parent 3d08cd07dd
commit 6e76b907c7
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
builtin/providers/google/resource_compute_snapshot_test.go
View File

@ -8,6 +8,7 @@ import (
"github.com/hashicorp/terraform/helper/resource" "github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform" "github.com/hashicorp/terraform/terraform"
"google.golang.org/api/compute/v1" "google.golang.org/api/compute/v1"
"google.golang.org/api/googleapi"
) )
func TestAccComputeSnapshot_basic(t *testing.T) { func TestAccComputeSnapshot_basic(t *testing.T) {
@ -64,9 +65,15 @@ func testAccCheckComputeSnapshotDestroy(s *terraform.State) error {
_, err := config.clientCompute.Snapshots.Get( _, err := config.clientCompute.Snapshots.Get(
config.Project, rs.Primary.ID).Do() config.Project, rs.Primary.ID).Do()
if err == nil { if err != nil {
return fmt.Errorf("Snapshot still exists") if gerr, ok := err.(*googleapi.Error); ok && gerr.Code == 404 {
return nil
} else if ok {
return fmt.Errorf("Error while requesting Google Cloud Plateform: http code error : %d, http message error: %s", gerr.Code, gerr.Message)
} }
return fmt.Errorf("Error while requesting Google Cloud Plateform")
}
return fmt.Errorf("Snapshot still exists")
} }
return nil return nil