ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

provider/aws: error with empty list item on sg 

This addresses the case where `compact` has not been used on a list
passed into security group as cidr_block. See #3786. Compact is still
the correct answer there, but we should prefer returning an error to
a panic. Fixes #3786.
This commit is contained in:
James Nugent 2015-12-01 15:22:02 -05:00
parent f80655b1ce
commit 69272f3113
1 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
builtin/providers/aws/resource_aws_security_group_rule.go
View File

@ -93,7 +93,10 @@ func resourceAwsSecurityGroupRuleCreate(d *schema.ResourceData, meta interface{}
return err return err
} }
perm := expandIPPerm(d, sg) perm, err := expandIPPerm(d, sg)
if err != nil {
return err
}
ruleType := d.Get("type").(string) ruleType := d.Get("type").(string)
@ -171,7 +174,10 @@ func resourceAwsSecurityGroupRuleRead(d *schema.ResourceData, meta interface{})
rules = sg.IpPermissionsEgress rules = sg.IpPermissionsEgress
} }
p := expandIPPerm(d, sg) p, err := expandIPPerm(d, sg)
if err != nil {
return err
}
if len(rules) == 0 { if len(rules) == 0 {
log.Printf("[WARN] No %s rules were found for Security Group (%s) looking for Security Group Rule (%s)", log.Printf("[WARN] No %s rules were found for Security Group (%s) looking for Security Group Rule (%s)",
@ -262,7 +268,10 @@ func resourceAwsSecurityGroupRuleDelete(d *schema.ResourceData, meta interface{}
return err return err
} }
perm := expandIPPerm(d, sg) perm, err := expandIPPerm(d, sg)
if err != nil {
return err
}
ruleType := d.Get("type").(string) ruleType := d.Get("type").(string)
switch ruleType { switch ruleType {
case "ingress": case "ingress":
@ -383,7 +392,7 @@ func ipPermissionIDHash(sg_id, ruleType string, ip *ec2.IpPermission) string {
return fmt.Sprintf("sgrule-%d", hashcode.String(buf.String())) return fmt.Sprintf("sgrule-%d", hashcode.String(buf.String()))
} }
func expandIPPerm(d *schema.ResourceData, sg *ec2.SecurityGroup) *ec2.IpPermission { func expandIPPerm(d *schema.ResourceData, sg *ec2.SecurityGroup) (*ec2.IpPermission, error) {
var perm ec2.IpPermission var perm ec2.IpPermission
perm.FromPort = aws.Int64(int64(d.Get("from_port").(int))) perm.FromPort = aws.Int64(int64(d.Get("from_port").(int)))
@ -435,9 +444,13 @@ func expandIPPerm(d *schema.ResourceData, sg *ec2.SecurityGroup) *ec2.IpPermissi
list := raw.([]interface{}) list := raw.([]interface{})
perm.IpRanges = make([]*ec2.IpRange, len(list)) perm.IpRanges = make([]*ec2.IpRange, len(list))
for i, v := range list { for i, v := range list {
perm.IpRanges[i] = &ec2.IpRange{CidrIp: aws.String(v.(string))} cidrIP, ok := v.(string)
if !ok {
return nil, fmt.Errorf("empty element found in cidr_blocks - consider using the compact function")
}
perm.IpRanges[i] = &ec2.IpRange{CidrIp: aws.String(cidrIP)}
} }
} }
return &perm return &perm, nil
} }