From 6257aff6765f99977e17edb4d6b02eb680cdbeb0 Mon Sep 17 00:00:00 2001 From: Paddy Date: Wed, 8 Feb 2017 10:24:04 -0800 Subject: [PATCH] provider/google: update DNS names in tests. Our DNS tests were using terraform.test as a DNS name, which GCP was erroring on, as we haven't proven we own the domain (and can't, as we don't). To solve this, I updated the tests to use hashicorptest.com, which we _do_ own, and which we have proven ownership of. The tests now pass. --- .../providers/google/resource_dns_managed_zone_test.go | 2 +- builtin/providers/google/resource_dns_record_set_test.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/providers/google/resource_dns_managed_zone_test.go b/builtin/providers/google/resource_dns_managed_zone_test.go index c136c8e10..73d55128f 100644 --- a/builtin/providers/google/resource_dns_managed_zone_test.go +++ b/builtin/providers/google/resource_dns_managed_zone_test.go @@ -79,5 +79,5 @@ func testAccCheckDnsManagedZoneExists(n string, zone *dns.ManagedZone) resource. var testAccDnsManagedZone_basic = fmt.Sprintf(` resource "google_dns_managed_zone" "foobar" { name = "mzone-test-%s" - dns_name = "terraform.test." + dns_name = "hashicorptest.com." }`, acctest.RandString(10)) diff --git a/builtin/providers/google/resource_dns_record_set_test.go b/builtin/providers/google/resource_dns_record_set_test.go index 1a128b7d3..35e1ac347 100644 --- a/builtin/providers/google/resource_dns_record_set_test.go +++ b/builtin/providers/google/resource_dns_record_set_test.go @@ -138,12 +138,12 @@ func testAccDnsRecordSet_basic(zoneName string, addr2 string, ttl int) string { return fmt.Sprintf(` resource "google_dns_managed_zone" "parent-zone" { name = "%s" - dns_name = "terraform.test." + dns_name = "hashicorptest.com." description = "Test Description" } resource "google_dns_record_set" "foobar" { managed_zone = "${google_dns_managed_zone.parent-zone.name}" - name = "test-record.terraform.test." + name = "test-record.hashicorptest.com." type = "A" rrdatas = ["127.0.0.1", "%s"] ttl = %d @@ -155,12 +155,12 @@ func testAccDnsRecordSet_bigChange(zoneName string, ttl int) string { return fmt.Sprintf(` resource "google_dns_managed_zone" "parent-zone" { name = "%s" - dns_name = "terraform.test." + dns_name = "hashicorptest.com." description = "Test Description" } resource "google_dns_record_set" "foobar" { managed_zone = "${google_dns_managed_zone.parent-zone.name}" - name = "test-record.terraform.test." + name = "test-record.hashicorptest.com." type = "CNAME" rrdatas = ["www.terraform.io."] ttl = %d