ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #27834 from hashicorp/pselle/ignore-changes-wildcard 

Upgrade ignore_changes wildcard from warning to error
This commit is contained in:
Pam Selle 2021-02-19 16:16:39 -05:00 committed by GitHub
parent cbacc53b34 230658f2b2
commit 61bee3cd44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
configs/resource.go
View File

@ -204,9 +204,9 @@ func decodeResourceBlock(block *hcl.Block) (*Resource, hcl.Diagnostics) {
r.Managed.IgnoreAllChanges = true r.Managed.IgnoreAllChanges = true
ignoreAllRange = expr.Range() ignoreAllRange = expr.Range()
diags = append(diags, &hcl.Diagnostic{ diags = append(diags, &hcl.Diagnostic{
Severity: hcl.DiagWarning, Severity: hcl.DiagError,
Summary: "Deprecated ignore_changes wildcard", Summary: "Invalid ignore_changes wildcard",
Detail: "The [\"*\"] form of ignore_changes wildcard is deprecated. Use \"ignore_changes = all\" to ignore changes to all attributes.", Detail: "The [\"*\"] form of ignore_changes wildcard is was deprecated and is now invalid. Use \"ignore_changes = all\" to ignore changes to all attributes.",
Subject: attr.Expr.Range().Ptr(), Subject: attr.Expr.Range().Ptr(),
}) })
continue continue

5
configs/testdata/error-files/ignore_changes.tf vendored Normal file
View File

@ -0,0 +1,5 @@
resource "null_resource" "all" {
lifecycle {
ignore_changes = ["*"] # ERROR: Invalid ignore_changes wildcard
}
}

11
configs/testdata/warning-files/ignore_changes.tf vendored
View File

@ -1,11 +0,0 @@
resource "null_resource" "one" {
lifecycle {
ignore_changes = ["triggers"] # WARNING: Quoted references are deprecated
}
}
resource "null_resource" "all" {
lifecycle {
ignore_changes = ["*"] # WARNING: Deprecated ignore_changes wildcard
}
}

4
terraform/context_apply_test.go
View File

@ -8372,8 +8372,8 @@ func TestContext2Apply_ignoreChangesWithDep(t *testing.T) {
} }
} }
func TestContext2Apply_ignoreChangesWildcard(t *testing.T) { func TestContext2Apply_ignoreChangesAll(t *testing.T) {
m := testModule(t, "apply-ignore-changes-wildcard") m := testModule(t, "apply-ignore-changes-all")
p := testProvider("aws") p := testProvider("aws")
p.PlanResourceChangeFn = testDiffFn p.PlanResourceChangeFn = testDiffFn
p.ApplyResourceChangeFn = testApplyFn p.ApplyResourceChangeFn = testApplyFn

2
terraform/testdata/apply-ignore-changes-wildcard/main.tf → terraform/testdata/apply-ignore-changes-all/main.tf vendored
View File

@ -2,6 +2,6 @@ resource "aws_instance" "foo" {
required_field = "set" required_field = "set"
lifecycle { lifecycle {
ignore_changes = ["*"] ignore_changes = all
} }
} }