Merge pull request #96 from jorgeng87/master

Add check for valid AWS region

builtin/providers/aws/config.go

@@ -1,6 +1,7 @@
 package aws
 
 import (
+	"fmt"
 	"os"
 	"strings"
 	"unicode"
@@ -29,12 +30,30 @@ func (c *Config) AWSAuth() (aws.Auth, error) {
 	return auth, err
 }
 
+// IsValidRegion returns true if the configured region is a valid AWS
+// region and false if it's not
+func (c *Config) IsValidRegion() bool {
+	var regions = [8]string{"us-east-1", "us-west-2", "us-west-1", "eu-west-1",
+		"ap-southeast-1", "ap-southeast-2", "ap-northeast-1", "sa-east-1"}
+
+	for _, valid := range regions {
+		if c.Region == valid {
+			return true
+		}
+	}
+	return false
+}
+
 // AWSRegion returns the configured region.
 //
 // TODO(mitchellh): Test in some way.
 func (c *Config) AWSRegion() (aws.Region, error) {
 	if c.Region != "" {
+		if c.IsValidRegion() {
 			return aws.Regions[c.Region], nil
+		} else {
+			return aws.Region{}, fmt.Errorf("Not a valid region: %s", c.Region)
+		}
 	}
 
 	if v := os.Getenv("AWS_REGION"); v != "" {

builtin/providers/aws/resource_provider_test.go

@@ -30,7 +30,7 @@ func TestResourceProvider_Configure(t *testing.T) {
 	raw := map[string]interface{}{
 		"access_key": "foo",
 		"secret_key": "bar",
-		"region":     "us-east",
+		"region":     "us-east-1",
 	}
 
 	rawConfig, err := config.NewRawConfig(raw)
@@ -46,7 +46,7 @@ func TestResourceProvider_Configure(t *testing.T) {
 	expected := Config{
 		AccessKey: "foo",
 		SecretKey: "bar",
-		Region:    "us-east",
+		Region:    "us-east-1",
 	}
 
 	if !reflect.DeepEqual(rp.Config, expected) {