ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove eval TODO for NormalizeObjectFromLegacySDK 

The normalization will take place in the provider shims, locating it
with the rest of the code that attempts to match the new and legacy
behavior.
This commit is contained in:
James Bardin 2019-03-06 16:23:56 -05:00
parent 5c40d6610c
commit 5c09f94695
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
terraform/eval_apply.go
View File

@ -203,12 +203,6 @@ func (n *EvalApply) Eval(ctx EvalContext) (interface{}, error) {
// on the planned value, and thus get a different result during the // on the planned value, and thus get a different result during the
// apply phase. This will usually lead to a "Provider produced invalid plan" // apply phase. This will usually lead to a "Provider produced invalid plan"
// error that incorrectly blames the downstream resource for the change. // error that incorrectly blames the downstream resource for the change.
//
// TODO: Ideally we should use objchange.NormalizeObjectFromLegacySDK
// here so the rest of Terraform is shielded from some of the oddities
// of the legacy SDK, but for the moment we've done that only in
// format.ResourceChange to reduce the risk of unexpected impacts
// elsewhere.
} else { } else {
for _, err := range errs { for _, err := range errs {

6
terraform/eval_diff.go
View File

@ -229,12 +229,6 @@ func (n *EvalDiff) Eval(ctx EvalContext) (interface{}, error) {
fmt.Fprintf(&buf, "\n - %s", tfdiags.FormatError(err)) fmt.Fprintf(&buf, "\n - %s", tfdiags.FormatError(err))
} }
log.Print(buf.String()) log.Print(buf.String())
// TODO: Ideally we should use objchange.NormalizeObjectFromLegacySDK
// here so the rest of Terraform is shielded from some of the oddities
// of the legacy SDK, but for the moment we've done that only in
// format.ResourceChange to reduce the risk of unexpected impacts
// elsewhere.
} else { } else {
for _, err := range errs { for _, err := range errs {
diags = diags.Append(tfdiags.Sourceless( diags = diags.Append(tfdiags.Sourceless(