ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4746 from hashicorp/b-detect-weird-json 

config: detect provisioner-only resource in JSON and error [GH-4385]
This commit is contained in:
Mitchell Hashimoto 2016-01-19 12:31:29 -08:00
parent 7ab19c62e6 8e7b0d90e3
commit 585d0943d9
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
config/loader_hcl.go
View File

@ -405,6 +405,15 @@ func loadResourcesHcl(list *ast.ObjectList) ([]*Resource, error) {
// Now go over all the types and their children in order to get // Now go over all the types and their children in order to get
// all of the actual resources. // all of the actual resources.
for _, item := range list.Items { for _, item := range list.Items {
// GH-4385: We detect a pure provisioner resource and give the user
// an error about how to do it cleanly.
if len(item.Keys) == 4 && item.Keys[2].Token.Value().(string) == "provisioner" {
return nil, fmt.Errorf(
"position %s: provisioners in a resource should be wrapped in a list\n\n"+
"Example: \"provisioner\": [ { \"local-exec\": ... } ]",
item.Pos())
}
if len(item.Keys) != 2 { if len(item.Keys) != 2 {
return nil, fmt.Errorf( return nil, fmt.Errorf(
"position %s: resource must be followed by exactly two strings, a type and a name", "position %s: resource must be followed by exactly two strings, a type and a name",