From 57c1a8dada2990829a4fbb96461f7b244c60ffc0 Mon Sep 17 00:00:00 2001
From: Mitchell Hashimoto <mitchell.hashimoto@gmail.com>
Date: Fri, 26 Sep 2014 15:49:51 -0700
Subject: [PATCH] config: add IsEmptyDir

---
 config/loader.go      | 121 ++++++++++++++++++++++++------------------
 config/loader_test.go |  20 +++++++
 2 files changed, 88 insertions(+), 53 deletions(-)

diff --git a/config/loader.go b/config/loader.go
index 5cc27e998..da74e9762 100644
--- a/config/loader.go
+++ b/config/loader.go
@@ -42,62 +42,10 @@ func Load(path string) (*Config, error) {
 //
 // Files are loaded in lexical order.
 func LoadDir(root string) (*Config, error) {
-	var files, overrides []string
-
-	f, err := os.Open(root)
+	files, overrides, err := dirFiles(root)
 	if err != nil {
 		return nil, err
 	}
-
-	fi, err := f.Stat()
-	if err != nil {
-		return nil, err
-	}
-	if !fi.IsDir() {
-		return nil, fmt.Errorf(
-			"configuration path must be a directory: %s",
-			root)
-	}
-
-	err = nil
-	for err != io.EOF {
-		var fis []os.FileInfo
-		fis, err = f.Readdir(128)
-		if err != nil && err != io.EOF {
-			f.Close()
-			return nil, err
-		}
-
-		for _, fi := range fis {
-			// Ignore directories
-			if fi.IsDir() {
-				continue
-			}
-
-			// Only care about files that are valid to load
-			name := fi.Name()
-			extValue := ext(name)
-			if extValue == "" {
-				continue
-			}
-
-			// Determine if we're dealing with an override
-			nameNoExt := name[:len(name)-len(extValue)]
-			override := nameNoExt == "override" ||
-				strings.HasSuffix(nameNoExt, "_override")
-
-			path := filepath.Join(root, name)
-			if override {
-				overrides = append(overrides, path)
-			} else {
-				files = append(files, path)
-			}
-		}
-	}
-
-	// Close the directory, we're done with it
-	f.Close()
-
 	if len(files) == 0 {
 		return nil, fmt.Errorf(
 			"No Terraform configuration files found in directory: %s",
@@ -152,6 +100,17 @@ func LoadDir(root string) (*Config, error) {
 	return result, nil
 }
 
+// IsEmptyDir returns true if the directory given has no Terraform
+// configuration files.
+func IsEmptyDir(root string) (bool, error) {
+	fs, os, err := dirFiles(root)
+	if err != nil {
+		return false, err
+	}
+
+	return len(fs) == 0 && len(os) == 0, nil
+}
+
 // Ext returns the Terraform configuration extension of the given
 // path, or a blank string if it is an invalid function.
 func ext(path string) string {
@@ -163,3 +122,59 @@ func ext(path string) string {
 		return ""
 	}
 }
+
+func dirFiles(dir string) ([]string, []string, error) {
+	f, err := os.Open(dir)
+	if err != nil {
+		return nil, nil, err
+	}
+	defer f.Close()
+
+	fi, err := f.Stat()
+	if err != nil {
+		return nil, nil, err
+	}
+	if !fi.IsDir() {
+		return nil, nil, fmt.Errorf(
+			"configuration path must be a directory: %s",
+			dir)
+	}
+
+	var files, overrides []string
+	err = nil
+	for err != io.EOF {
+		var fis []os.FileInfo
+		fis, err = f.Readdir(128)
+		if err != nil && err != io.EOF {
+			return nil, nil, err
+		}
+
+		for _, fi := range fis {
+			// Ignore directories
+			if fi.IsDir() {
+				continue
+			}
+
+			// Only care about files that are valid to load
+			name := fi.Name()
+			extValue := ext(name)
+			if extValue == "" {
+				continue
+			}
+
+			// Determine if we're dealing with an override
+			nameNoExt := name[:len(name)-len(extValue)]
+			override := nameNoExt == "override" ||
+				strings.HasSuffix(nameNoExt, "_override")
+
+			path := filepath.Join(dir, name)
+			if override {
+				overrides = append(overrides, path)
+			} else {
+				files = append(files, path)
+			}
+		}
+	}
+
+	return files, overrides, nil
+}
diff --git a/config/loader_test.go b/config/loader_test.go
index f95235d66..da4a2dd8f 100644
--- a/config/loader_test.go
+++ b/config/loader_test.go
@@ -6,6 +6,26 @@ import (
 	"testing"
 )
 
+func TestIsEmptyDir(t *testing.T) {
+	val, err := IsEmptyDir(fixtureDir)
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+	if val {
+		t.Fatal("should not be empty")
+	}
+}
+
+func TestIsEmptyDir_noConfigs(t *testing.T) {
+	val, err := IsEmptyDir(filepath.Join(fixtureDir, "dir-empty"))
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+	if !val {
+		t.Fatal("should be empty")
+	}
+}
+
 func TestLoad_badType(t *testing.T) {
 	_, err := Load(filepath.Join(fixtureDir, "bad_type.tf.nope"))
 	if err == nil {