From 533b7238b1da196fea7191addbe3a930a8aa5da0 Mon Sep 17 00:00:00 2001
From: Peter Beams <peter.beams@wiggle.co.uk>
Date: Tue, 3 Mar 2015 12:57:11 +0000
Subject: [PATCH] can create, update & delete eni

---
 .../aws/resource_aws_network_interface.go     | 100 +++++++++++++++---
 1 file changed, 85 insertions(+), 15 deletions(-)

diff --git a/builtin/providers/aws/resource_aws_network_interface.go b/builtin/providers/aws/resource_aws_network_interface.go
index b4d23cd43..96437c18d 100644
--- a/builtin/providers/aws/resource_aws_network_interface.go
+++ b/builtin/providers/aws/resource_aws_network_interface.go
@@ -42,11 +42,6 @@ func resourceAwsNetworkInterface() *schema.Resource {
 				},
 			},
 
-			"source_dest_check": &schema.Schema{
-				Type:     schema.TypeBool,
-				Optional: true,
-			},			
-
 			"security_groups": &schema.Schema{
 				Type:     schema.TypeSet,
 				Optional: true,
@@ -66,10 +61,10 @@ func resourceAwsNetworkInterfaceCreate(d *schema.ResourceData, meta interface{})
 	
 	ec2conn := meta.(*AWSClient).ec2conn2
 
-		request := &ec2.CreateNetworkInterfaceRequest{
-		Description:			aws.String("xxx"),
+	request := &ec2.CreateNetworkInterfaceRequest{		
 		Groups: 				expandStringList(d.Get("security_groups").(*schema.Set).List()),
 		SubnetID:				aws.String(d.Get("subnet_id").(string)),
+		PrivateIPAddresses:		convertToPrivateIPAddresses(d.Get("private_ips").(*schema.Set).List()),
 	}
 	
 	log.Printf("[DEBUG] Creating network interface")
@@ -80,35 +75,76 @@ func resourceAwsNetworkInterfaceCreate(d *schema.ResourceData, meta interface{})
 
 	new_interface_id := *resp.NetworkInterface.NetworkInterfaceID
 	d.SetId(new_interface_id)
+	log.Printf("[INFO] ENI ID: %s", d.Id())
 
-	
-	// chain to update here
-	return nil
-
+	return resourceAwsNetworkInterfaceUpdate(d, meta)	
 }
 
 func resourceAwsNetworkInterfaceRead(d *schema.ResourceData, meta interface{}) error {
 
 	ec2conn := meta.(*AWSClient).ec2conn2
 	describe_network_interfaces_request := &ec2.DescribeNetworkInterfacesRequest{		
+		NetworkInterfaceIDs:	[]string{d.Id()},
 	}
 	describeResp, err := ec2conn.DescribeNetworkInterfaces(describe_network_interfaces_request)
 
 	if err != nil {
-		return nil
+		if ec2err, ok := err.(aws.APIError); ok && ec2err.Code == "InvalidNetworkInterfaceID.NotFound" {
+			// The ENI is gone now, so just remove it from the state
+			d.SetId("")
+			return nil
+		}
+		
+		return fmt.Errorf("Error retrieving ENI: %s", err)
 	}
-	if describeResp != nil {
-		return nil
+	if len(describeResp.NetworkInterfaces) != 1 {
+		return fmt.Errorf("Unable to find ENI: %#v", describeResp.NetworkInterfaces)
 	}
 
+	eni := describeResp.NetworkInterfaces[0]
+	d.Set("subnet_id", eni.SubnetID)
+	d.Set("private_ips", convertToJustAddresses(eni.PrivateIPAddresses))
+	d.Set("security_groups", convertToGroupIds(eni.Groups))
+	
 	return nil
 }
 
 func resourceAwsNetworkInterfaceUpdate(d *schema.ResourceData, meta interface{}) error {
-	return nil
+
+	d.Partial(true)
+
+	if d.HasChange("security_groups") {
+		request := &ec2.ModifyNetworkInterfaceAttributeRequest{
+			NetworkInterfaceID:		aws.String(d.Id()),
+			Groups:					expandStringList(d.Get("security_groups").(*schema.Set).List()),
+		}
+
+		ec2conn := meta.(*AWSClient).ec2conn2
+		err := ec2conn.ModifyNetworkInterfaceAttribute(request)
+		if err != nil {
+			return fmt.Errorf("Failure updating ENI: %s", err)
+		}
+
+		d.SetPartial("security_groups")
+	}
+
+	d.Partial(false)
+
+	return resourceAwsNetworkInterfaceRead(d, meta)
 }
 
 func resourceAwsNetworkInterfaceDelete(d *schema.ResourceData, meta interface{}) error {
+	ec2conn := meta.(*AWSClient).ec2conn2
+
+	log.Printf("[INFO] Deleting ENI: %s", d.Id())
+
+	deleteEniOpts := ec2.DeleteNetworkInterfaceRequest{
+		NetworkInterfaceID: aws.String(d.Id()),
+	}
+	if err := ec2conn.DeleteNetworkInterface(&deleteEniOpts); err != nil {
+		return fmt.Errorf("Error deleting ENI: %s", err)
+	}
+
 	return nil
 }
 
@@ -116,4 +152,38 @@ func resourceAwsNetworkInterfaceDelete(d *schema.ResourceData, meta interface{})
 // an EC2 instance.
 func NetworkInterfaceStateRefreshFunc(conn *ec2.EC2, instanceID string) resource.StateRefreshFunc {
 	return nil
+}
+
+func convertToJustAddresses(dtos []ec2.NetworkInterfacePrivateIPAddress) []string {
+	ips := make([]string, 0, len(dtos))
+	for _, v := range dtos {
+		ip := *v.PrivateIPAddress
+		ips = append(ips, ip)
+	}
+	return ips
+}
+
+func convertToGroupIds(dtos []ec2.GroupIdentifier) []string {
+	ids := make([]string, 0, len(dtos))
+	for _, v := range dtos {
+		group_id := *v.GroupID
+		ids = append(ids, group_id)
+	}
+	return ids
+}
+
+func convertToPrivateIPAddresses(ips []interface{}) []ec2.PrivateIPAddressSpecification {
+	dtos := make([]ec2.PrivateIPAddressSpecification, 0, len(ips))
+	for i, v := range ips {
+		new_private_ip := ec2.PrivateIPAddressSpecification{
+			PrivateIPAddress:	aws.String(v.(string)),
+		}	
+		
+		if i == 0 {
+			new_private_ip.Primary = aws.Boolean(true)
+		}
+
+		dtos = append(dtos, new_private_ip)
+	}
+	return dtos
 }
\ No newline at end of file