terraform: disallow simple variables ("foo")

Fixes #5338 (and I'm sure many others)

There is no use case for "simple" variables in Terraform at all so
anytime one is found it should be an error.

There is a _huge_ backwards incompatibility here that was not supposed
to be by design but I'm sure a lot of people are relying on: in the
`template_file` datasource, this bug allowed you to not escape your
interpolations and have the work. For example:

```
data "template_file" "foo" {
  template = "${a}"
  vars { a = 12 }
}
```

The above would work, but it shouldn't. The template should have to be
`"$${a}"` (to escape the interpolation).

Because of this BC, I recommend holding this until Terraform 0.8.0 and
documenting it carefully. As part of this PR, I've added some special
error message notes.
This commit is contained in:
Mitchell Hashimoto 2016-10-28 15:20:25 -04:00
parent 7940af2ff2
commit 3fd390b699
No known key found for this signature in database
GPG Key ID: 744E147AA52F5B0A
2 changed files with 14 additions and 6 deletions

View File

@ -284,12 +284,14 @@ func (i *Interpolater) valueSimpleVar(
n string, n string,
v *config.SimpleVariable, v *config.SimpleVariable,
result map[string]ast.Variable) error { result map[string]ast.Variable) error {
// SimpleVars are never handled by Terraform's interpolator // This error message includes some information for people who
result[n] = ast.Variable{ // relied on this for their template_file data sources. We should
Value: config.UnknownVariableValue, // remove this at some point but there isn't any rush.
Type: ast.TypeString, return fmt.Errorf(
} "invalid variable syntax: %q. If this is part of inline `template` parameter\n" +
return nil "then you must escape the interpolation with two dollar signs. For\n" +
"example: ${a} becomes $${a}." +
n)
} }
func (i *Interpolater) valueUserVar( func (i *Interpolater) valueUserVar(

View File

@ -13,6 +13,12 @@ import (
"github.com/hashicorp/terraform/config" "github.com/hashicorp/terraform/config"
) )
func TestInterpolater_simpleVar(t *testing.T) {
i := &Interpolater{}
scope := &InterpolationScope{}
testInterpolateErr(t, i, scope, "simple")
}
func TestInterpolater_countIndex(t *testing.T) { func TestInterpolater_countIndex(t *testing.T) {
i := &Interpolater{} i := &Interpolater{}