From 3d8005729d3e307535ea505c63fc238aae7beb87 Mon Sep 17 00:00:00 2001
From: Clint Shryock <clint@ctshryock.com>
Date: Thu, 19 Mar 2015 15:10:49 -0500
Subject: [PATCH] provider/aws: Fix dependency violation with subnets and
 security groups

Though not directly connected, trying to delete a subnet and security group in
parallel can cause a dependency violation from the subnet, claiming there are
dependencies.

This commit fixes that by allowing subnet deletion to tolerate failure with a
retry / refresh function.

Fixes #934
---
 builtin/providers/aws/resource_aws_subnet.go | 37 +++++++++++++++-----
 1 file changed, 29 insertions(+), 8 deletions(-)

diff --git a/builtin/providers/aws/resource_aws_subnet.go b/builtin/providers/aws/resource_aws_subnet.go
index d1db5aed9..4922b035f 100644
--- a/builtin/providers/aws/resource_aws_subnet.go
+++ b/builtin/providers/aws/resource_aws_subnet.go
@@ -157,17 +157,38 @@ func resourceAwsSubnetDelete(d *schema.ResourceData, meta interface{}) error {
 	ec2conn := meta.(*AWSClient).ec2conn
 
 	log.Printf("[INFO] Deleting subnet: %s", d.Id())
-
-	err := ec2conn.DeleteSubnet(&ec2.DeleteSubnetRequest{
+	req := &ec2.DeleteSubnetRequest{
 		SubnetID: aws.String(d.Id()),
-	})
+	}
 
-	if err != nil {
-		ec2err, ok := err.(aws.APIError)
-		if ok && ec2err.Code == "InvalidSubnetID.NotFound" {
-			return nil
-		}
+	wait := resource.StateChangeConf{
+		Pending:    []string{"pending"},
+		Target:     "destroyed",
+		Timeout:    5 * time.Minute,
+		MinTimeout: 1 * time.Second,
+		Refresh: func() (interface{}, string, error) {
+			err := ec2conn.DeleteSubnet(req)
+			if err != nil {
+				if apiErr, ok := err.(aws.APIError); ok {
+					if apiErr.Code == "DependencyViolation" {
+						// There is some pending operation, so just retry
+						// in a bit.
+						return 42, "pending", nil
+					}
 
+					if apiErr.Code == "InvalidSubnetID.NotFound" {
+						return 42, "destroyed", nil
+					}
+				}
+
+				return 42, "failure", err
+			}
+
+			return 42, "destroyed", nil
+		},
+	}
+
+	if _, err := wait.WaitForState(); err != nil {
 		return fmt.Errorf("Error deleting subnet: %s", err)
 	}