ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a test to ensure that workspaces must have a unique name in pg backend

This commit is contained in:
Rémi Lapeyre 2021-07-14 11:57:28 +02:00
parent 43f698dc9d
commit 3bf053a5fc
1 changed files with 35 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
internal/backend/remote-state/pg/backend_test.go
View File

@ -89,11 +89,13 @@ func TestBackendConfigSkipOptions(t *testing.T) {
SkipSchemaCreation bool SkipSchemaCreation bool
SkipTableCreation bool SkipTableCreation bool
SkipIndexCreation bool SkipIndexCreation bool
TestIndexIsPresent bool
Setup func(t *testing.T, db *sql.DB, schemaName string) Setup func(t *testing.T, db *sql.DB, schemaName string)
}{ }{
{ {
Name: "skip_schema_creation", Name: "skip_schema_creation",
SkipSchemaCreation: true, SkipSchemaCreation: true,
TestIndexIsPresent: true,
Setup: func(t *testing.T, db *sql.DB, schemaName string) { Setup: func(t *testing.T, db *sql.DB, schemaName string) {
// create the schema as a prerequisites // create the schema as a prerequisites
_, err := db.Query(fmt.Sprintf(`CREATE SCHEMA IF NOT EXISTS %s`, schemaName)) _, err := db.Query(fmt.Sprintf(`CREATE SCHEMA IF NOT EXISTS %s`, schemaName))
@ -105,6 +107,7 @@ func TestBackendConfigSkipOptions(t *testing.T) {
{ {
Name: "skip_table_creation", Name: "skip_table_creation",
SkipTableCreation: true, SkipTableCreation: true,
TestIndexIsPresent: true,
Setup: func(t *testing.T, db *sql.DB, schemaName string) { Setup: func(t *testing.T, db *sql.DB, schemaName string) {
// since the table needs to be already created the schema must be too // since the table needs to be already created the schema must be too
_, err := db.Query(fmt.Sprintf(`CREATE SCHEMA %s`, schemaName)) _, err := db.Query(fmt.Sprintf(`CREATE SCHEMA %s`, schemaName))
@ -124,6 +127,7 @@ func TestBackendConfigSkipOptions(t *testing.T) {
{ {
Name: "skip_index_creation", Name: "skip_index_creation",
SkipIndexCreation: true, SkipIndexCreation: true,
TestIndexIsPresent: true,
Setup: func(t *testing.T, db *sql.DB, schemaName string) { Setup: func(t *testing.T, db *sql.DB, schemaName string) {
// Everything need to exists for the index to be created // Everything need to exists for the index to be created
_, err := db.Query(fmt.Sprintf(`CREATE SCHEMA %s`, schemaName)) _, err := db.Query(fmt.Sprintf(`CREATE SCHEMA %s`, schemaName))
@ -144,6 +148,10 @@ func TestBackendConfigSkipOptions(t *testing.T) {
} }
}, },
}, },
{
Name: "missing_index",
SkipIndexCreation: true,
},
} }
for _, tc := range testCases { for _, tc := range testCases {
@ -163,7 +171,9 @@ func TestBackendConfigSkipOptions(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
if tc.Setup != nil {
tc.Setup(t, db, schemaName) tc.Setup(t, db, schemaName)
}
defer db.Query(fmt.Sprintf("DROP SCHEMA IF EXISTS %s CASCADE", schemaName)) defer db.Query(fmt.Sprintf("DROP SCHEMA IF EXISTS %s CASCADE", schemaName))
b := backend.TestBackendConfig(t, New(), config).(*Backend) b := backend.TestBackendConfig(t, New(), config).(*Backend)
@ -179,6 +189,7 @@ func TestBackendConfigSkipOptions(t *testing.T) {
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
if tc.TestIndexIsPresent {
// Make sure that the index exists // Make sure that the index exists
query := `select count(*) from pg_indexes where schemaname=$1 and tablename=$2 and indexname=$3;` query := `select count(*) from pg_indexes where schemaname=$1 and tablename=$2 and indexname=$3;`
var count int var count int
@ -188,6 +199,7 @@ func TestBackendConfigSkipOptions(t *testing.T) {
if count != 1 { if count != 1 {
t.Fatalf("The index has not been created (%d)", count) t.Fatalf("The index has not been created (%d)", count)
} }
}
_, err = b.StateMgr(backend.DefaultStateName) _, err = b.StateMgr(backend.DefaultStateName)
if err != nil { if err != nil {
@ -202,6 +214,16 @@ func TestBackendConfigSkipOptions(t *testing.T) {
if c.Name != backend.DefaultStateName { if c.Name != backend.DefaultStateName {
t.Fatal("RemoteClient name is not configured") t.Fatal("RemoteClient name is not configured")
} }
// Make sure that all workspace must have a unique name
_, err = db.Exec(fmt.Sprintf(`INSERT INTO %s.%s VALUES (100, 'unique_name_test', '')`, schemaName, statesTableName))
if err != nil {
t.Fatal(err)
}
_, err = db.Exec(fmt.Sprintf(`INSERT INTO %s.%s VALUES (101, 'unique_name_test', '')`, schemaName, statesTableName))
if err == nil {
t.Fatal("Creating two workspaces with the same name did not raise an error")
}
}) })
} }