ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

terraform: staticcheck

This commit is contained in:
James Bardin 2020-12-01 15:51:54 -05:00
parent 41d4dd82d6
commit 3a6c32cb1c
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
terraform/context_validate_test.go
View File

@ -1273,7 +1273,7 @@ output "out" {
} }
// Should get this error: // Should get this error:
// Unsupported attribute: This object does not have an attribute named "missing" // Unsupported attribute: This object does not have an attribute named "missing"
if got, want := diags.Err().Error(), "Unsupported attribute"; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), "Unsupported attribute"; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1310,7 +1310,7 @@ resource "aws_instance" "foo" {
} }
// Should get this error: // Should get this error:
// Unsupported attribute: This object does not have an attribute named "missing" // Unsupported attribute: This object does not have an attribute named "missing"
if got, want := diags.Err().Error(), "Unsupported attribute"; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), "Unsupported attribute"; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1350,7 +1350,7 @@ resource "aws_instance" "foo" {
} }
// Should get this error: // Should get this error:
// Output refers to sensitive values: Expressions used in outputs can only refer to sensitive values if the sensitive attribute is true. // Output refers to sensitive values: Expressions used in outputs can only refer to sensitive values if the sensitive attribute is true.
if got, want := diags.Err().Error(), "Output refers to sensitive values"; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), "Output refers to sensitive values"; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1379,7 +1379,7 @@ output "out" {
} }
// Should get this error: // Should get this error:
// Invalid resource count attribute: The special "count" attribute is no longer supported after Terraform v0.12. Instead, use length(aws_instance.test) to count resource instances. // Invalid resource count attribute: The special "count" attribute is no longer supported after Terraform v0.12. Instead, use length(aws_instance.test) to count resource instances.
if got, want := diags.Err().Error(), "Invalid resource count attribute:"; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), "Invalid resource count attribute:"; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1410,7 +1410,7 @@ output "out" {
} }
// Should get this error: // Should get this error:
// Reference to undeclared module: No module call named "foo" is declared in the root module. // Reference to undeclared module: No module call named "foo" is declared in the root module.
if got, want := diags.Err().Error(), "Reference to undeclared module:"; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), "Reference to undeclared module:"; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1441,7 +1441,7 @@ output "out" {
} }
// Should get this error: // Should get this error:
// Reference to undeclared module: No module call named "foo" is declared in the root module. // Reference to undeclared module: No module call named "foo" is declared in the root module.
if got, want := diags.Err().Error(), "Reference to undeclared module:"; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), "Reference to undeclared module:"; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1471,7 +1471,7 @@ resource "test_instance" "bar" {
} }
// Should get this error: // Should get this error:
// Reference to undeclared module: No module call named "foo" is declared in the root module. // Reference to undeclared module: No module call named "foo" is declared in the root module.
if got, want := diags.Err().Error(), "Reference to undeclared resource:"; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), "Reference to undeclared resource:"; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1504,7 +1504,7 @@ resource "test_instance" "bar" {
} }
// Should get this error: // Should get this error:
// Reference to undeclared module: No module call named "foo" is declared in the root module. // Reference to undeclared module: No module call named "foo" is declared in the root module.
if got, want := diags.Err().Error(), `no argument, nested block, or exported attribute named "does_not_exist_in_schema"`; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), `no argument, nested block, or exported attribute named "does_not_exist_in_schema"`; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1527,7 +1527,7 @@ func TestContext2Validate_variableCustomValidationsFail(t *testing.T) {
if !diags.HasErrors() { if !diags.HasErrors() {
t.Fatal("succeeded; want errors") t.Fatal("succeeded; want errors")
} }
if got, want := diags.Err().Error(), `Invalid value for variable: Value must not be "nope".`; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), `Invalid value for variable: Value must not be "nope".`; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1660,7 +1660,7 @@ resource "aws_instance" "foo" {
if !diags.HasErrors() { if !diags.HasErrors() {
t.Fatal("succeeded; want errors") t.Fatal("succeeded; want errors")
} }
if got, want := diags.Err().Error(), `Invalid count argument`; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), `Invalid count argument`; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }
@ -1692,7 +1692,7 @@ resource "aws_instance" "foo" {
if !diags.HasErrors() { if !diags.HasErrors() {
t.Fatal("succeeded; want errors") t.Fatal("succeeded; want errors")
} }
if got, want := diags.Err().Error(), `Invalid for_each argument`; strings.Index(got, want) == -1 { if got, want := diags.Err().Error(), `Invalid for_each argument`; !strings.Contains(got, want) {
t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want) t.Fatalf("wrong error:\ngot: %s\nwant: message containing %q", got, want)
} }
} }