From 38f76ddc4eaf1da79de26e4eb6f7ae032d1d0d09 Mon Sep 17 00:00:00 2001
From: James Bardin <j.bardin@gmail.com>
Date: Wed, 17 Jan 2018 18:31:05 -0500
Subject: [PATCH] the trailing slash check caused a nil dereference

The disco package doesn't return errors, and a nil value indicates that
the input isn't valid. Always check for nil.
---
 registry/client.go      |  3 +++
 registry/client_test.go | 17 +++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/registry/client.go b/registry/client.go
index b4cd7989f..358343569 100644
--- a/registry/client.go
+++ b/registry/client.go
@@ -67,6 +67,9 @@ func NewClient(services *disco.Disco, creds auth.CredentialsSource, client *http
 // Discover qeuries the host, and returns the url for the registry.
 func (c *Client) Discover(host svchost.Hostname) *url.URL {
 	service := c.services.DiscoverServiceURL(host, serviceID)
+	if service == nil {
+		return nil
+	}
 	if !strings.HasSuffix(service.Path, "/") {
 		service.Path += "/"
 	}
diff --git a/registry/client_test.go b/registry/client_test.go
index a4ef640ed..279c5a483 100644
--- a/registry/client_test.go
+++ b/registry/client_test.go
@@ -55,6 +55,23 @@ func TestLookupModuleVersions(t *testing.T) {
 	}
 }
 
+func TestInvalidRegistry(t *testing.T) {
+	server := test.Registry()
+	defer server.Close()
+
+	client := NewClient(test.Disco(server), nil, nil)
+
+	src := "non-existent.localhost.localdomain/test-versions/name/provider"
+	modsrc, err := regsrc.ParseModuleSource(src)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if _, err := client.Versions(modsrc); err == nil {
+		t.Fatal("expected error")
+	}
+}
+
 func TestRegistryAuth(t *testing.T) {
 	server := test.Registry()
 	defer server.Close()