From 30cf550fc5f55457dc9e9446a43a7460be470497 Mon Sep 17 00:00:00 2001
From: Mitchell Hashimoto <mitchell.hashimoto@gmail.com>
Date: Mon, 11 Apr 2016 17:40:23 -0700
Subject: [PATCH] terraform: can't move module to module that exists

---
 terraform/state_add.go  |  6 ++++++
 terraform/state_test.go | 38 ++++++++++++++++++++++++++++++++++----
 2 files changed, 40 insertions(+), 4 deletions(-)

diff --git a/terraform/state_add.go b/terraform/state_add.go
index ee6e266ba..9a485c0f8 100644
--- a/terraform/state_add.go
+++ b/terraform/state_add.go
@@ -61,6 +61,12 @@ func (s *State) Add(addrRaw string, raw interface{}) error {
 func stateAddFunc_Module_Module(s *State, addr *ResourceAddress, raw interface{}) error {
 	src := raw.(*ModuleState)
 
+	// If the target module exists, it is an error
+	path := append([]string{"root"}, addr.Path...)
+	if s.ModuleByPath(path) != nil {
+		return fmt.Errorf("module target is not empty: %s", addr)
+	}
+
 	// TODO: outputs
 	// TODO: dependencies
 
diff --git a/terraform/state_test.go b/terraform/state_test.go
index 2ef0906b2..d9a53b69f 100644
--- a/terraform/state_test.go
+++ b/terraform/state_test.go
@@ -426,11 +426,13 @@ func TestStateIncrementSerialMaybe(t *testing.T) {
 
 func TestStateAdd(t *testing.T) {
 	cases := map[string]struct {
+		Err      bool
 		Address  string
 		Value    interface{}
 		One, Two *State
 	}{
 		"ModuleState => Module Addr (new)": {
+			false,
 			"module.foo",
 			&ModuleState{
 				Path: rootModulePath,
@@ -475,17 +477,45 @@ func TestStateAdd(t *testing.T) {
 				},
 			},
 		},
+
+		"ModuleState => Module Addr (existing)": {
+			true,
+			"module.foo",
+			&ModuleState{},
+			&State{
+				Modules: []*ModuleState{
+					&ModuleState{
+						Path: []string{"root", "foo"},
+						Resources: map[string]*ResourceState{
+							"test_instance.baz": &ResourceState{
+								Type: "test_instance",
+								Primary: &InstanceState{
+									ID: "foo",
+								},
+							},
+						},
+					},
+				},
+			},
+			nil,
+		},
 	}
 
 	for k, tc := range cases {
 		// Make sure they're both initialized as normal
 		tc.One.init()
-		tc.Two.init()
+		if tc.Two != nil {
+			tc.Two.init()
+		}
 
 		// Add the value
-		if err := tc.One.Add(tc.Address, tc.Value); err != nil {
+		err := tc.One.Add(tc.Address, tc.Value)
+		if (err != nil) != tc.Err {
 			t.Fatalf("bad: %s\n\n%s", k, err)
 		}
+		if tc.Err {
+			continue
+		}
 
 		// Prune them both to be sure
 		tc.One.prune()
@@ -493,8 +523,8 @@ func TestStateAdd(t *testing.T) {
 
 		// Verify equality
 		if !tc.One.Equal(tc.Two) {
-			t.Fatalf("Bad: %s\n\n%#v\n\n%#v", k, tc.One, tc.Two)
-			//t.Fatalf("Bad: %s\n\n%s\n\n%s", k, tc.One.String(), tc.Two.String())
+			//t.Fatalf("Bad: %s\n\n%#v\n\n%#v", k, tc.One, tc.Two)
+			t.Fatalf("Bad: %s\n\n%s\n\n%s", k, tc.One.String(), tc.Two.String())
 		}
 	}
 }