ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

internal/getproviders: Distinguished packed vs. unpacked local packages 

Our local filesystem mirror mechanism will allow provider packages to be
given either in packed form as an archive directly downloaded to disk or
in an unpacked form where the archive is extracted.

Distinguishing these two cases in the concrete Location types will allow
callers to reliably select the mode chosen by the selected installation
source and handle it appropriately, rather than resorting to out-of-band
heuristics like checking whether the object is a directory or a file.
This commit is contained in:
Martin Atkins 2020-01-09 17:54:16 -08:00
parent 92a58ec438
commit 2aac8cf812
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
internal/getproviders/types.go
View File

@ -59,19 +59,27 @@ type PackageMeta struct {
} }
// PackageLocation represents a location where a provider distribution package // PackageLocation represents a location where a provider distribution package
// can be obtained. A value of this type contains either a PackageLocalPath or a // can be obtained. A value of this type contains one of the following
// PackageHTTPURL value. // concrete types: PackageLocalArchive, PackageLocalDir, or PackageHTTPURL.
type PackageLocation interface { type PackageLocation interface {
packageLocation() packageLocation()
} }
// PackageLocalPath is a provider package location in the local filesystem. // PackageLocalArchive is the location of a provider distribution archive file
// Its value is a local filesystem path using the syntax understood by Go's // in the local filesystem. Its value is a local filesystem path using the
// standard path/filepath package on the operating system where Terraform is // syntax understood by Go's standard path/filepath package on the operating
// running. // system where Terraform is running.
type PackageLocalPath string type PackageLocalArchive string
func (p PackageLocalPath) packageLocation() {} func (p PackageLocalArchive) packageLocation() {}
// PackageLocalDir is the location of a directory containing an unpacked
// provider distribution archive in the local filesystem. Its value is a local
// filesystem path using the syntax understood by Go's standard path/filepath
// package on the operating system where Terraform is running.
type PackageLocalDir string
func (p PackageLocalDir) packageLocation() {}
// PackageHTTPURL is a provider package location accessible via HTTP. // PackageHTTPURL is a provider package location accessible via HTTP.
// Its value is a URL string using either the http: scheme or the https: scheme. // Its value is a URL string using either the http: scheme or the https: scheme.