comment cleanup: those FIXME comments are load-bearing and must be up to date

terraform/eval_context_builtin.go

@@ -148,9 +148,6 @@ func (ctx *BuiltinEvalContext) Provider(addr addrs.AbsProviderConfig) providers.
 
 func (ctx *BuiltinEvalContext) ProviderSchema(addr addrs.AbsProviderConfig) *ProviderSchema {
 	ctx.once.Do(ctx.init)
-
-	// FIXME: Once AbsProviderConfig starts containing an FQN, use that directly
-	// here instead of addr.ProviderConfig.LocalName.
 	return ctx.Schemas.ProviderSchema(addr.Provider)
 }
 

terraform/eval_context_builtin_test.go

@@ -64,10 +64,6 @@ func TestBuildingEvalContextInitProvider(t *testing.T) {
 		},
 	}
 
-	// FIXME: Once AbsProviderConfig has a provider FQN instead of an
-	// embedded LocalProviderConfig, use a legacy or default provider address
-	// here depending on whether we've moved away from legacy provider
-	// addresses in general yet.
 	providerAddrDefault := addrs.AbsProviderConfig{
 		Module:   addrs.RootModuleInstance,
 		Provider: addrs.NewLegacyProvider("test"),

terraform/module_dependencies.go

@@ -192,8 +192,6 @@ func configTreeMergeStateDependencies(root *moduledeps.Module, state *states.Sta
 		module := findModule(ms.Addr)
 
 		for _, rs := range ms.Resources {
-			//FIXME: lookup the provider localname in the TBD map and see if
-			//there is an FQN associated
 			fqn := rs.ProviderConfig.Provider
 			if _, exists := module.Providers[fqn]; !exists {
 				module.Providers[fqn] = moduledeps.ProviderDependency{

terraform/resource_provider.go

@@ -237,7 +237,8 @@ func ResourceProviderResolverFixed(factories map[addrs.Provider]ResourceProvider
 		ret := make(map[addrs.Provider]ResourceProviderFactory, len(reqd))
 		var errs []error
 		for name := range reqd {
-			// Provider Source Readiness!
+			// FIXME: discovery.PluginRequirements should use addrs.Provider as
+			// the map keys instead of a string
 			fqn := addrs.NewLegacyProvider(name)
 			if factory, exists := factories[fqn]; exists {
 				ret[fqn] = factory

terraform/transform_provider.go

@@ -668,11 +668,6 @@ func (t *ProviderConfigTransformer) addProxyProviders(g *Graph, c *configs.Confi
 	// Go through all the providers the parent is passing in, and add proxies to
 	// the parent provider nodes.
 	for _, pair := range parentCfg.Providers {
-
-		// FIXME: this is relying on assumptions that the only providers are
-		// legacy-style providers, and will instead need to lookup fqns from the
-		// config when that information is available.
-		//fullAddr := pair.InChild.Addr().Absolute(instPath)
 		fqn := c.Module.ProviderForLocalConfig(pair.InChild.Addr())
 		fullAddr := addrs.AbsProviderConfig{
 			Provider: fqn,