From 2a0334125c0db514bc1fb5aa1cb5df9845342f5e Mon Sep 17 00:00:00 2001
From: James Nugent <james@jen20.com>
Date: Mon, 9 Nov 2015 15:15:25 -0500
Subject: [PATCH] Add test attempting to reproduce #2598

This attempts to reproduce the issue described in #2598 whereby outputs
added after an apply are not reflected in the output. As per the issue
the outputs are described using the JSON syntax.
---
 terraform/context_apply_test.go               | 49 +++++++++++++++++++
 terraform/terraform_test.go                   | 16 ++++++
 .../apply-output-add-after/main.tf            |  6 +++
 .../apply-output-add-after/outputs.tf.json    | 10 ++++
 .../apply-output-add-before/main.tf           |  6 +++
 .../apply-output-add-before/outputs.tf.json   |  7 +++
 6 files changed, 94 insertions(+)
 create mode 100644 terraform/test-fixtures/apply-output-add-after/main.tf
 create mode 100644 terraform/test-fixtures/apply-output-add-after/outputs.tf.json
 create mode 100644 terraform/test-fixtures/apply-output-add-before/main.tf
 create mode 100644 terraform/test-fixtures/apply-output-add-before/outputs.tf.json

diff --git a/terraform/context_apply_test.go b/terraform/context_apply_test.go
index 1fd069db0..4060dd3e3 100644
--- a/terraform/context_apply_test.go
+++ b/terraform/context_apply_test.go
@@ -2851,6 +2851,55 @@ func TestContext2Apply_outputInvalid(t *testing.T) {
 	}
 }
 
+func TestContext2Apply_outputAdd(t *testing.T) {
+	m1 := testModule(t, "apply-output-add-before")
+	p1 := testProvider("aws")
+	p1.ApplyFn = testApplyFn
+	p1.DiffFn = testDiffFn
+	ctx1 := testContext2(t, &ContextOpts{
+		Module: m1,
+		Providers: map[string]ResourceProviderFactory{
+			"aws": testProviderFuncFixed(p1),
+		},
+	})
+
+	if _, err := ctx1.Plan(); err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	state1, err := ctx1.Apply()
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	m2 := testModule(t, "apply-output-add-after")
+	p2 := testProvider("aws")
+	p2.ApplyFn = testApplyFn
+	p2.DiffFn = testDiffFn
+	ctx2 := testContext2(t, &ContextOpts{
+		Module: m2,
+		Providers: map[string]ResourceProviderFactory{
+			"aws": testProviderFuncFixed(p2),
+		},
+		State: state1,
+	})
+
+	if _, err := ctx2.Plan(); err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	state2, err := ctx2.Apply()
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	actual := strings.TrimSpace(state2.String())
+	expected := strings.TrimSpace(testTerraformApplyOutputAddStr)
+	if actual != expected {
+		t.Fatalf("bad: \n%s", actual)
+	}
+}
+
 func TestContext2Apply_outputList(t *testing.T) {
 	m := testModule(t, "apply-output-list")
 	p := testProvider("aws")
diff --git a/terraform/terraform_test.go b/terraform/terraform_test.go
index d17726acb..3b1653f43 100644
--- a/terraform/terraform_test.go
+++ b/terraform/terraform_test.go
@@ -575,6 +575,22 @@ Outputs:
 foo_num = 2
 `
 
+const testTerraformApplyOutputAddStr = `
+aws_instance.test.0:
+  ID = foo
+  foo = foo0
+  type = aws_instance
+aws_instance.test.1:
+  ID = foo
+  foo = foo1
+  type = aws_instance
+
+Outputs:
+
+firstOutput = foo0
+secondOutput = foo1
+`
+
 const testTerraformApplyOutputListStr = `
 aws_instance.bar.0:
   ID = foo
diff --git a/terraform/test-fixtures/apply-output-add-after/main.tf b/terraform/test-fixtures/apply-output-add-after/main.tf
new file mode 100644
index 000000000..1c10eaafc
--- /dev/null
+++ b/terraform/test-fixtures/apply-output-add-after/main.tf
@@ -0,0 +1,6 @@
+provider "aws" {}
+
+resource "aws_instance" "test" {
+		foo = "${format("foo%d", count.index)}"
+		count = 2
+}
diff --git a/terraform/test-fixtures/apply-output-add-after/outputs.tf.json b/terraform/test-fixtures/apply-output-add-after/outputs.tf.json
new file mode 100644
index 000000000..32e96b0ee
--- /dev/null
+++ b/terraform/test-fixtures/apply-output-add-after/outputs.tf.json
@@ -0,0 +1,10 @@
+{
+		"output": {
+				"firstOutput": {
+						"value": "${aws_instance.test.0.foo}"
+				},
+				"secondOutput": {
+						"value": "${aws_instance.test.1.foo}"
+				}
+		}
+}
diff --git a/terraform/test-fixtures/apply-output-add-before/main.tf b/terraform/test-fixtures/apply-output-add-before/main.tf
new file mode 100644
index 000000000..1c10eaafc
--- /dev/null
+++ b/terraform/test-fixtures/apply-output-add-before/main.tf
@@ -0,0 +1,6 @@
+provider "aws" {}
+
+resource "aws_instance" "test" {
+		foo = "${format("foo%d", count.index)}"
+		count = 2
+}
diff --git a/terraform/test-fixtures/apply-output-add-before/outputs.tf.json b/terraform/test-fixtures/apply-output-add-before/outputs.tf.json
new file mode 100644
index 000000000..238668ef3
--- /dev/null
+++ b/terraform/test-fixtures/apply-output-add-before/outputs.tf.json
@@ -0,0 +1,7 @@
+{
+		"output": {
+				"firstOutput": {
+						"value": "${aws_instance.test.0.foo}"
+				}
+		}
+}