Upgrade ignore_changes wildcard from warning to error

The syntax ignore_changes = ["*"] was deprecated and now errors.
Use = all instead.

configs/resource.go

@@ -211,9 +211,9 @@ func decodeResourceBlock(block *hcl.Block) (*Resource, hcl.Diagnostics) {
 							r.Managed.IgnoreAllChanges = true
 							ignoreAllRange = expr.Range()
 							diags = append(diags, &hcl.Diagnostic{
-								Severity: hcl.DiagWarning,
+								Severity: hcl.DiagError,
-								Summary:  "Deprecated ignore_changes wildcard",
+								Summary:  "Invalid ignore_changes wildcard",
-								Detail:   "The [\"*\"] form of ignore_changes wildcard is deprecated. Use \"ignore_changes = all\" to ignore changes to all attributes.",
+								Detail:   "The [\"*\"] form of ignore_changes wildcard is was deprecated and is now invalid. Use \"ignore_changes = all\" to ignore changes to all attributes.",
 								Subject:  attr.Expr.Range().Ptr(),
 							})
 							continue

configs/testdata/error-files/ignore_changes.tf

@@ -0,0 +1,5 @@
+resource "null_resource" "all" {
+  lifecycle {
+    ignore_changes = ["*"] # ERROR: Invalid ignore_changes wildcard
+  }
+}

configs/testdata/warning-files/ignore_changes.tf

@@ -1,11 +0,0 @@
-resource "null_resource" "one" {
-  lifecycle {
-    ignore_changes = ["triggers"] # WARNING: Quoted references are deprecated
-  }
-}
-
-resource "null_resource" "all" {
-  lifecycle {
-    ignore_changes = ["*"] # WARNING: Deprecated ignore_changes wildcard
-  }
-}

terraform/context_apply_test.go

@@ -8372,8 +8372,8 @@ func TestContext2Apply_ignoreChangesWithDep(t *testing.T) {
 	}
 }
 
-func TestContext2Apply_ignoreChangesWildcard(t *testing.T) {
+func TestContext2Apply_ignoreChangesAll(t *testing.T) {
-	m := testModule(t, "apply-ignore-changes-wildcard")
+	m := testModule(t, "apply-ignore-changes-all")
 	p := testProvider("aws")
 	p.PlanResourceChangeFn = testDiffFn
 	p.ApplyResourceChangeFn = testApplyFn

terraform/testdata/apply-ignore-changes-all/main.tf

@@ -2,6 +2,6 @@ resource "aws_instance" "foo" {
   required_field = "set"
 
   lifecycle {
-    ignore_changes = ["*"]
+    ignore_changes = all
   }
 }