update tests to cover icmp

builtin/providers/aws/resource_aws_security_group_rule_test.go

@@ -592,9 +592,6 @@ resource "aws_vpc" "tftest" {
 }
 
 resource "aws_security_group" "web" {
-  name        = "terraform_acceptance_test_example"
-  description = "Used in the terraform acceptance tests"
-
   vpc_id = "${aws_vpc.tftest.id}"
 
   tags {

builtin/providers/aws/resource_aws_security_group_test.go

@@ -44,6 +44,18 @@ func TestProtocolStateFunc(t *testing.T) {
 			input:    -1,
 			expected: "",
 		},
+		{
+			input:    "1",
+			expected: "icmp",
+		},
+		{
+			input:    "icmp",
+			expected: "icmp",
+		},
+		{
+			input:    1,
+			expected: "",
+		},
 	}
 	for _, c := range cases {
 		result := protocolStateFunc(c.input)
@@ -102,6 +114,14 @@ func TestProtocolForValue(t *testing.T) {
 			input:    "ALL",
 			expected: "-1",
 		},
+		{
+			input:    "icMp",
+			expected: "icmp",
+		},
+		{
+			input:    "1",
+			expected: "icmp",
+		},
 	}
 
 	for _, c := range cases {