providers/aws: remove password from resource diff to not trigger changes
cc/ @mitchellh This one caught me a bit, and I'm not sure if there's another AttrType that could be useful here – perhaps a AttrTypeHidden or something? I don't know...this feels sloppy to have in the diff func.
This commit is contained in:
parent
9a2685cf13
commit
0ca0b8dd62
|
@ -206,7 +206,7 @@ func resource_aws_db_instance_diff(
|
||||||
"maintenance_window": diff.AttrTypeCreate,
|
"maintenance_window": diff.AttrTypeCreate,
|
||||||
"multi_az": diff.AttrTypeCreate,
|
"multi_az": diff.AttrTypeCreate,
|
||||||
"name": diff.AttrTypeCreate,
|
"name": diff.AttrTypeCreate,
|
||||||
"password": diff.AttrTypeCreate,
|
"password": diff.AttrTypeUpdate,
|
||||||
"port": diff.AttrTypeCreate,
|
"port": diff.AttrTypeCreate,
|
||||||
"publicly_accessible": diff.AttrTypeCreate,
|
"publicly_accessible": diff.AttrTypeCreate,
|
||||||
"username": diff.AttrTypeCreate,
|
"username": diff.AttrTypeCreate,
|
||||||
|
@ -226,10 +226,21 @@ func resource_aws_db_instance_diff(
|
||||||
"multi_az",
|
"multi_az",
|
||||||
"port",
|
"port",
|
||||||
"address",
|
"address",
|
||||||
|
"password",
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
return b.Diff(s, c)
|
rd, err := b.Diff(s, c)
|
||||||
|
if err != nil {
|
||||||
|
return rd, err
|
||||||
|
}
|
||||||
|
|
||||||
|
// Remove the password from the resource diff, so Terraform
|
||||||
|
// doesn't think it will change (we don't store the password)
|
||||||
|
// in state for security reasons, so it will always be "" otherwise
|
||||||
|
delete(rd.Attributes, "password")
|
||||||
|
|
||||||
|
return rd, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func resource_aws_db_instance_update_state(
|
func resource_aws_db_instance_update_state(
|
||||||
|
|
Loading…
Reference in New Issue