ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #30684 from hashicorp/alisdair/fix-sum-func 

functions: Fix sum() of all strings
This commit is contained in:
Alisdair McDiarmid 2022-03-16 12:56:38 -04:00 committed by GitHub
parent 3727191078 0764726e3e
commit 0bf4112c28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/lang/funcs/collection.go
View File

@ -527,6 +527,10 @@ var SumFunc = function.New(&function.Spec{
if s.IsNull() { if s.IsNull() {
return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple of number values") return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple of number values")
} }
s, err = convert.Convert(s, cty.Number)
if err != nil {
return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple of number values")
}
for _, v := range arg[1:] { for _, v := range arg[1:] {
if v.IsNull() { if v.IsNull() {
return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple of number values") return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple of number values")

9
internal/lang/funcs/collection_test.go
View File

@ -1629,6 +1629,15 @@ func TestSum(t *testing.T) {
cty.NilVal, cty.NilVal,
"can't compute sum of opposing infinities", "can't compute sum of opposing infinities",
}, },
{
cty.ListVal([]cty.Value{
cty.StringVal("1"),
cty.StringVal("2"),
cty.StringVal("3"),
}),
cty.NumberIntVal(6),
"",
},
} }
for _, test := range tests { for _, test := range tests {