update test; fix import, interpolate ENV var for log name
This commit is contained in:
parent
285a88b664
commit
0bf127a805
|
@ -2,16 +2,18 @@ package aws
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"os"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
|
"github.com/aws/aws-sdk-go/aws"
|
||||||
"github.com/aws/aws-sdk-go/service/ec2"
|
"github.com/aws/aws-sdk-go/service/ec2"
|
||||||
"github.com/hashicorp/aws-sdk-go/aws"
|
|
||||||
"github.com/hashicorp/terraform/helper/resource"
|
"github.com/hashicorp/terraform/helper/resource"
|
||||||
"github.com/hashicorp/terraform/terraform"
|
"github.com/hashicorp/terraform/terraform"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestAccFlowLog_basic(t *testing.T) {
|
func TestAccFlowLog_basic(t *testing.T) {
|
||||||
var flowLog ec2.FlowLog
|
var flowLog ec2.FlowLog
|
||||||
|
lgn := os.Getenv("LOG_GROUP_NAME")
|
||||||
|
|
||||||
resource.Test(t, resource.TestCase{
|
resource.Test(t, resource.TestCase{
|
||||||
PreCheck: func() { testAccPreCheck(t) },
|
PreCheck: func() { testAccPreCheck(t) },
|
||||||
|
@ -19,7 +21,7 @@ func TestAccFlowLog_basic(t *testing.T) {
|
||||||
CheckDestroy: testAccCheckFlowLogDestroy,
|
CheckDestroy: testAccCheckFlowLogDestroy,
|
||||||
Steps: []resource.TestStep{
|
Steps: []resource.TestStep{
|
||||||
resource.TestStep{
|
resource.TestStep{
|
||||||
Config: testAccFlowLogConfig_basic,
|
Config: fmt.Sprintf(testAccFlowLogConfig_basic, lgn),
|
||||||
Check: resource.ComposeTestCheckFunc(
|
Check: resource.ComposeTestCheckFunc(
|
||||||
testAccCheckFlowLogExists("aws_flow_log.test_flow_log", &flowLog),
|
testAccCheckFlowLogExists("aws_flow_log.test_flow_log", &flowLog),
|
||||||
testAccCheckAWSFlowLogAttributes(&flowLog),
|
testAccCheckAWSFlowLogAttributes(&flowLog),
|
||||||
|
@ -31,6 +33,7 @@ func TestAccFlowLog_basic(t *testing.T) {
|
||||||
|
|
||||||
func TestAccFlowLog_subnet(t *testing.T) {
|
func TestAccFlowLog_subnet(t *testing.T) {
|
||||||
var flowLog ec2.FlowLog
|
var flowLog ec2.FlowLog
|
||||||
|
lgn := os.Getenv("LOG_GROUP_NAME")
|
||||||
|
|
||||||
resource.Test(t, resource.TestCase{
|
resource.Test(t, resource.TestCase{
|
||||||
PreCheck: func() { testAccPreCheck(t) },
|
PreCheck: func() { testAccPreCheck(t) },
|
||||||
|
@ -38,7 +41,7 @@ func TestAccFlowLog_subnet(t *testing.T) {
|
||||||
CheckDestroy: testAccCheckFlowLogDestroy,
|
CheckDestroy: testAccCheckFlowLogDestroy,
|
||||||
Steps: []resource.TestStep{
|
Steps: []resource.TestStep{
|
||||||
resource.TestStep{
|
resource.TestStep{
|
||||||
Config: testAccFlowLogConfig_subnet,
|
Config: fmt.Sprintf(testAccFlowLogConfig_subnet, lgn),
|
||||||
Check: resource.ComposeTestCheckFunc(
|
Check: resource.ComposeTestCheckFunc(
|
||||||
testAccCheckFlowLogExists("aws_flow_log.test_flow_log_subnet", &flowLog),
|
testAccCheckFlowLogExists("aws_flow_log.test_flow_log_subnet", &flowLog),
|
||||||
testAccCheckAWSFlowLogAttributes(&flowLog),
|
testAccCheckAWSFlowLogAttributes(&flowLog),
|
||||||
|
@ -152,7 +155,7 @@ resource "aws_flow_log" "test_flow_log" {
|
||||||
resource "aws_flow_log" "test_flow_log_subnet" {
|
resource "aws_flow_log" "test_flow_log_subnet" {
|
||||||
# log_group_name needs to exist before hand
|
# log_group_name needs to exist before hand
|
||||||
# until we have a CloudWatch Log Group Resource
|
# until we have a CloudWatch Log Group Resource
|
||||||
log_group_name = "tf-test-log-group"
|
log_group_name = "%s"
|
||||||
iam_role_arn = "${aws_iam_role.test_role.arn}"
|
iam_role_arn = "${aws_iam_role.test_role.arn}"
|
||||||
subnet_id = "${aws_subnet.test_subnet.id}"
|
subnet_id = "${aws_subnet.test_subnet.id}"
|
||||||
traffic_type = "ALL"
|
traffic_type = "ALL"
|
||||||
|
@ -201,7 +204,7 @@ EOF
|
||||||
resource "aws_flow_log" "test_flow_log_subnet" {
|
resource "aws_flow_log" "test_flow_log_subnet" {
|
||||||
# log_group_name needs to exist before hand
|
# log_group_name needs to exist before hand
|
||||||
# until we have a CloudWatch Log Group Resource
|
# until we have a CloudWatch Log Group Resource
|
||||||
log_group_name = "tf-test-log-group"
|
log_group_name = "%s"
|
||||||
iam_role_arn = "${aws_iam_role.test_role.arn}"
|
iam_role_arn = "${aws_iam_role.test_role.arn}"
|
||||||
subnet_id = "${aws_subnet.test_subnet.id}"
|
subnet_id = "${aws_subnet.test_subnet.id}"
|
||||||
traffic_type = "ALL"
|
traffic_type = "ALL"
|
||||||
|
|
Loading…
Reference in New Issue