From 2c98c0c33c71ab7b72df1ae3cfa81fed6d386b80 Mon Sep 17 00:00:00 2001 From: Sander van Harmelen Date: Thu, 25 Jun 2015 16:47:35 +0200 Subject: [PATCH 1/2] Update CHANGELOG The SSH agent thing applies to all provisioners using the `ssh` connection type, so it would be misleading to specifically write it related to the `remote-exec` provisioner. --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 91d1806a1..fc70e12ce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ BACKWARDS INCOMPATIBILITIES: - * `provisioner/remote-exec`: The `agent` field now defaults to `true` if + * `communicator/ssh`: The `agent` field now defaults to `true` if the `SSH_AGENT_SOCK` environment variable is present. In other words, `ssh-agent` support is now opt-out instead of opt-in functionality. [GH-2408] * `concat()` has been repurposed to combine lists instead of strings (old behavior @@ -31,7 +31,7 @@ FEATURES: a OpenStack Swift. [GH-2254] * command/output: support display of module outputs [GH-2102] * core: `keys()` and `values()` funcs for map variables [GH-2198] - * provisioner/remote-exec: SSH bastion host support and ssh-agent forwarding [GH-2425] + * communicator/ssh: SSH bastion host support and ssh-agent forwarding [GH-2425] IMPROVEMENTS: From 8e955b5c97d63a800bd8ea9a87e3b7d9a56f109f Mon Sep 17 00:00:00 2001 From: Sander van Harmelen Date: Thu, 25 Jun 2015 16:58:00 +0200 Subject: [PATCH 2/2] Updated again :smiley: The `connection` concept is something people know right? So maybe this would be a better description? --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fc70e12ce..39fe5a164 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ BACKWARDS INCOMPATIBILITIES: - * `communicator/ssh`: The `agent` field now defaults to `true` if + * `connection/ssh`: The `agent` field now defaults to `true` if the `SSH_AGENT_SOCK` environment variable is present. In other words, `ssh-agent` support is now opt-out instead of opt-in functionality. [GH-2408] * `concat()` has been repurposed to combine lists instead of strings (old behavior @@ -31,7 +31,7 @@ FEATURES: a OpenStack Swift. [GH-2254] * command/output: support display of module outputs [GH-2102] * core: `keys()` and `values()` funcs for map variables [GH-2198] - * communicator/ssh: SSH bastion host support and ssh-agent forwarding [GH-2425] + * connection/ssh: SSH bastion host support and ssh-agent forwarding [GH-2425] IMPROVEMENTS: